Noticed that some DB server specific code has been added to the Fluid Shell command classes. We probably should avoid doing that because it creates duplicated code and makes maintenance harder. All of SQL based commands are derived from the ShellSqlCommand class; in the past, we either create a method in ShellSqlCommand or create a static method in a utility class for handling DB server specific needs, we'd better continue doing so.
I are working on ERModler command implementation, and will review other sql based commands such as sqlimport, sqlexport, sqldump to make sure DB server specific code can be shared among them.
SVN r30627 - Some servers do not support -d|--database and -s|--schema options, moved server specific check from command classes to the base class; a warning message will be printed to standard error if these options are specified but server does not support them. Change has been made in the following commands: describe, erm, list, sqldump, sqlexport, sqlimport.
SVN r30627 - Some servers do not support -d|--database and -s|--schema options, moved server specific check from command classes to the base class; a warning message will be printed to standard error if these options are specified but server does not support them. Change has been made in the following commands: describe, erm, list, sqldump, sqlexport, sqlimport.
Verified using ADStudio 13 Alpha 14 that the cmds:
connect,
describe,
list,
reconnect,
sqlexport,
sqlimport,
sqldump
display warning messages when -d and/or -s params are specified.
Verified using ADStudio 13 Alpha 14 that the cmds:
connect,
describe,
list,
reconnect,
sqlexport,
sqlimport,
sqldump
display warning messages when -d and/or -s params are specified.
Fixed in Version: 13.0-rc-4 and Build #: 31199
Fixed in Version: 13.0-rc-4 and Build #: 31199
Issue #8045 |
Closed |
Fixed |
Resolved |
Completion |
No due date |
Fixed Build trunk/30533, 30627 |
No time estimate |
SVN r30533 - Schema validation can be done by calling ShellSqlCommand.validateSchema(...)