Aqua Data Studio 15.0.0-dev-82
Build #: 35685
Built on: 2014-Jan-24 05:27:23 PM
Connect to Paraccel
Create a table named 'organization'
Create table script:
Create a procedure named 'clean_emp'
Create procedure script:
|
205 KB
|
194 KB
|
195 KB
|
46 KB
In ADS 19 beta 30, I tested this scenario in Paraccel 5.1
Used same script given in main issue description.
1.When we rename function name in Alter Function UI and try to alter, we are still getting error message.
2.If we see in Preview SQL tab, SQL is generated as
Pls confirm at your end.
Function name is not renamed, hence reopening this issue.
In ADS 19 beta 30, I tested this scenario in Paraccel 5.1
Used same script given in main issue description.
1.When we rename function name in Alter Function UI and try to alter, we are still getting error message.
2.If we see in Preview SQL tab, SQL is generated as
Pls confirm at your end.
Function name is not renamed, hence reopening this issue.
The suggestion to remove the schema name from the ALTER FUNCTION statement only works if the schema is "public".
Take a look at the sample script in the issue description. The schema is "test_schema". If we don't specify the schema name in the ALTER FUNCTION statement, it'll complain that the function doesn't exist.
I've fixed FunctionDialog to do a DROP FUNCTION first and then CREATE OR REPLACE FUNCTION for ParAccel when the function is renamed.
The suggestion to remove the schema name from the ALTER FUNCTION statement only works if the schema is "public".
Take a look at the sample script in the issue description. The schema is "test_schema". If we don't specify the schema name in the ALTER FUNCTION statement, it'll complain that the function doesn't exist.
I've fixed FunctionDialog to do a DROP FUNCTION first and then CREATE OR REPLACE FUNCTION for ParAccel when the function is renamed.
The fix is for ParAccel only. [SP] Understood. But do we do the DROP FUNCTION for any other DB when the user chooses ALTER FUNCTION action in UI? I ask b/c it is possible that the DROP FUNCTION succeeds but thte CREATE OR REPLACE FUNCTION fails
[Jenny] Take a look at FunctionDialog, line 709, where ScriptFunction.scriptDROP is called for DBs that don't support CREATE OR REPLACE FUNCTION, ALTER FUNCTION, or REPLACE FUNCTION syntax.
Since the ALTER FUNCTION RENAME syntax doesn't work correctly for ParAccel, we can disable editing of the function name in the Function Dialog UI.
The fix is for ParAccel only. [SP] Understood. But do we do the DROP FUNCTION for any other DB when the user chooses ALTER FUNCTION action in UI? I ask b/c it is possible that the DROP FUNCTION succeeds but thte CREATE OR REPLACE FUNCTION fails
[Jenny] Take a look at FunctionDialog, line 709, where ScriptFunction.scriptDROP is called for DBs that don't support CREATE OR REPLACE FUNCTION, ALTER FUNCTION, or REPLACE FUNCTION syntax.
Since the ALTER FUNCTION RENAME syntax doesn't work correctly for ParAccel, we can disable editing of the function name in the Function Dialog UI.
I've reverted my previous code changes.
We've decided to disable editing of the function name in the Alter Function dialog for ParAccel. I've checked in this code change.
I've reverted my previous code changes.
We've decided to disable editing of the function name in the Alter Function dialog for ParAccel. I've checked in this code change.
Issue #11531 |
Verified |
Fixed |
Resolved |
Completion |
No due date |
Fixed Build ADS 19.0.0-beta-31 |
No time estimate |
3 issue links |
relates to #11314
Issue #11314Alter Function name is not working in PostgresSQL database. |
relates to #12315
Issue #12315Teradata : Double quotes are generated twice in Profile name for Alter window > Preview SQL tab |
relates to #12245
Issue #12245Greenplum - Generate incorrect Alter function script in preview sql tab. |
The fix for issue #11314 resolved this issue, too.