While testing issue 12988, found some more F5 Refresh related problems. These problems seem to have something to do with selected tab embedded in ADS tabbed pane, visual editors and floating windows. Below are a couple examples to demonstrate the problems.
In the following tests, I did not use QA builds, I simply launch ADS from my IDE. My desktop is running Windows 8.1. In the test steps below, a selected-tab refers to the selected tab in a tabbed pane embedded in either ADS window or a visual editor window or a floating query-panel-tab window. The tab header text of the selected tab in a tabbed pane is displayed in boldface.
There are some other cases that seem to require the coordination of selected tab among ADS tabbed pane, visual editors and floating windows, those problems are not logged since I was not able to reproduce those problems consistently. One example is tab displayed in a visual editor can become deselected, when this happens, hit F5 while visual editor window is selected will actually execute refresh in ADS.
--- Scenario 1 ---
(1) Launch ADS 16.0.0-dev-81 - this is the head of trunk
(2) Expand schema browser to a table node, right click this table node and select "Query Analyzer".
(3) Query Analyzer tab is opened, type a valid query and hit F5 key
--> Query is executed successfully.
(4) In schema browser, right click any table node and select "Create Table"
--> "Create Table" window is displayed, move this window so that it won't overlay with ADS window completely.
(5) Click the title bar of ADS window to make it the selected window.
(6) In ADS window, click the editor pane inside the query analyzer tab created by step (3) to make that tab the selected tab and hit F5 key.
--> Query is executed successfully.
(7) Click the "Create Table" window created by step (4) to make it the selected window and hit F5 key.
--> Nothing happened after F5 key is pressed.
(8) Click the title bar of ADS window to make it the selected window
--> Now, the editor pane inside the query tab created by step (3) should have window focus.
--> However, the tab itself is not presented as a selected-tab
(9) Simply type in a character (any character) from key board and hit F5 key
--> The query will NOT execute in ADS.
Variant: if you already have a query analyzer tab presented after ADS is launched, you don't need to execute steps 2-3.
This problem is seen in 16.0.0-dev-81
This problem is seen in 15.0.11-6.
This problem is seen in 14.0.19-4.
This problem is NOT seen in 13.0.6.
This problem is NOT seen in 12.0.23.
The difference is after step (8), the query analyzer tab will become the selected tab in ADS.
--- Scenario 2 ---
(21) Launch ADS 16.0.0-dev-81.
(22) Open a Query Analyzer tab (let's name this tab as tab-1), type a valid query and hit F5 key
--> Query is executed successfully.
(23) Open another Query Analyzer tab (let's name this tab as tab-2), type a valid query and hit F5 key
--> Query is executed successfully.
(24) Right click tab-2 header and select "Floating"
--> tab-2 is displayed in a floating window which becomes the selected window.
==> Note that tab-2 is not presented as a selected-tab in the floating window.
(25) While tab-2 floating window is selected, hit F5 key.
--> ADS becomes the selected window and query in ADS' tab-1 panel is executed but not query in tab-2 panel.
This problem is seen in 16.0.0-dev-81
This problem is seen in 15.0.11-6.
This problem is seen in 14.0.19-4.
This problem is NOT seen in 13.0.6.
This problem is NOT seen in 12.0.23.
The difference is after step (24), tab-2 is selected in the floating window.
Question about:
(4) In schema browser, right click any table node and select "Create Table"
--> "Create Table" window is displayed, move this window so that it won't overlay with ADS window completely.
because Create Table is launched as a tab, should there be a step 3-b, which is "Float the Create Table tab as a window"?
otherwise the Create Table tab automatically "won't overlay with ADS window completely." due to how our tabs work.
I will attempt these steps again, but with File > Options > General > "Use Floating windows for Visual Editing dialogs"
I will attempt these steps again, but with File > Options > General > "Use Floating windows for Visual Editing dialogs"
I will attempt these steps again, but with File > Options > General > "Use Floating windows for Visual Editing dialogs"Yes, this issue is about visual editor window, we need to turn this flag on.
I will attempt these steps again, but with File > Options > General > "Use Floating windows for Visual Editing dialogs"Yes, this issue is about visual editor window, we need to turn this flag on.
@kin-hong: only put in a fix for v16 if it is very low risk. Otherwise, lets push out to v17.
@kin-hong: only put in a fix for v16 if it is very low risk. Otherwise, lets push out to v17.
Issue #12994 |
New |
Completion |
No due date |
No fixed build |
No time estimate |
Question about:
because Create Table is launched as a tab, should there be a step 3-b, which is "Float the Create Table tab as a window"?
otherwise the Create Table tab automatically "won't overlay with ADS window completely." due to how our tabs work.