Add option Option->General->Workspace->[Save files on exit without prompting]. Default value is disabled.
When this option is enabled, and the application is closed, all modified files are saved without prompting.
If this option is enabled and [Confirm exit of application] is disabled, then an OS shutdown will shutdown ADS and save all files and workspace.
|
291 KB
|
461 KB
SVN r46103+r46104/17.0.0-rc-2
Before SVN r46103+r46104, when files are modified and ADS is exiting, user will be prompted a dialog and asked how s/he wants to handle the modified files. One of the option user can choose is 'Save All'. If user chose 'Save All' option, then no more dialog will be prompted afterward.
There is a global flag defined in ADS which is used to save the state of 'Save All' option displayed in the confirmation dialog. SVN r46103+r46104 check-ins simply set that 'Save All' global flag to true if "App is exiting and [Save files on exit without prompting] is on" before 'handle modified file' is executed. With this approach, the original logic of 'handle modified file' remains unchanged. After execution of 'handle modified file' is done, the 'Save All' flag is restored to its old state.
The 'Save All' global flag used to be defined in the CEditorPanelView.java which is an ADS specific class. The 'Save All' global flag now is moved to the com.common.ui.frame.FrameSaveFileOperation under aqua-external directory so that aqua-external classes can access it.
@nileshhmali,
> Scenario-06
> Launch ADS
> Saved Query analyzer tab persist after launching ADS.
> ADS File Menu->options->General->Save files on exit without prompt in:True.
> Modify saved file.
>
> Close Terminal
> "Close this terminal?" dialog box opens
> Click on close terminal button.
What is 'Close Terminal'? How to launch this dialog in ADS?
> you observed that,ADS window closed.
> Again restart ADS
> you will observed that,modified texts does not persist in query analyzer.
>
> Is it expected behavior for scenario-06 ?
>
> Please refer screenshot Rc-6.png
I did not see any problem described in Rc-6.png, am I missing something?
@nileshhmali,
> Scenario-06
> Launch ADS
> Saved Query analyzer tab persist after launching ADS.
> ADS File Menu->options->General->Save files on exit without prompt in:True.
> Modify saved file.
>
> Close Terminal
> "Close this terminal?" dialog box opens
> Click on close terminal button.
What is 'Close Terminal'? How to launch this dialog in ADS?
> you observed that,ADS window closed.
> Again restart ADS
> you will observed that,modified texts does not persist in query analyzer.
>
> Is it expected behavior for scenario-06 ?
>
> Please refer screenshot Rc-6.png
I did not see any problem described in Rc-6.png, am I missing something?
@nileshhmali,
> Scenario-06
> 1)Open ADS through terminal
I cannot debug ADS by doing this.
Can you please try 17.0.0-rc-1 or older 17.0 builds and see
(a) if you get a Save dialog prompted in this case?
(b) if you can get modified contents saved?
@nileshhmali,
> Scenario-06
> 1)Open ADS through terminal
I cannot debug ADS by doing this.
Can you please try 17.0.0-rc-1 or older 17.0 builds and see
(a) if you get a Save dialog prompted in this case?
(b) if you can get modified contents saved?
@nileshhmali,
I have tested scenario-06 in ADS-17.0.0-rc-1,
(a) if you get a Save dialog prompted in this case?
=>No,I have not observed any save dialog box appearing after closing terminal.
(b) if you can get modified contents saved?
=>No,Modified content does not saved in file,after closing terminal.
Thanks, then I think this means ADS never supported this before.
@nileshhmali,
I have tested scenario-06 in ADS-17.0.0-rc-1,
(a) if you get a Save dialog prompted in this case?
=>No,I have not observed any save dialog box appearing after closing terminal.
(b) if you can get modified contents saved?
=>No,Modified content does not saved in file,after closing terminal.
Thanks, then I think this means ADS never supported this before.
Issue #13730 |
Closed |
Fixed |
Resolved |
Completion |
No due date |
Fixed Build ADS 17.0.0-rc-2 |
No time estimate |
1 issue link |
relates to #13549
Issue #13549Review Workspace restore of ADS to see if Floating windows can be included |
SVN r46103+r46104/17.0.0-rc-2
Before SVN r46103+r46104, when files are modified and ADS is exiting, user will be prompted a dialog and asked how s/he wants to handle the modified files. One of the option user can choose is 'Save All'. If user chose 'Save All' option, then no more dialog will be prompted afterward.
There is a global flag defined in ADS which is used to save the state of 'Save All' option displayed in the confirmation dialog. SVN r46103+r46104 check-ins simply set that 'Save All' global flag to true if "App is exiting and [Save files on exit without prompting] is on" before 'handle modified file' is executed. With this approach, the original logic of 'handle modified file' remains unchanged. After execution of 'handle modified file' is done, the 'Save All' flag is restored to its old state.
The 'Save All' global flag used to be defined in the CEditorPanelView.java which is an ADS specific class. The 'Save All' global flag now is moved to the com.common.ui.frame.FrameSaveFileOperation under aqua-external directory so that aqua-external classes can access it.