#14633: GIT File Browser Status Bug - Modified Files does not get displayed in red color

tariqrahiman reported 2016-08-18T18:12:00Z · last modified 2016-08-24T18:11:07Z

GIT File Browser Status Bug - Modified Files does not get displayed in red color

customer request Pending verification in other release

Dev	abdullah
QA	tariqrahiman

Priority	Low
Complexity	Unknown

Component	App - Version Control - GIT
Version	17.0

GIT File Browser Status Bug

Steps to reproduce:

1. Open ADS v 16. Navigate to Files Tab, go to Filesystem, right click and select option Git -> Create Repository

2. Enter a name in your chosen folder

3. Add and Commit a new file

4. Now make a few changes. The file is marked in red color indicating changes have been made

5. Quit ADS v16 and open ADS v17.0.0-dev-9 or any version after this build

6. You can see that in ADAS v17.0.0-dev-9 and after, when a change is made to a file and saved, the icon for that file in the File Tree pane does not change color to indicate that it has not been committed yet. It appears in "Green" color which is the bug

See attached screenshot

Notes:

Broken in Product: Aqua Data Studio Version: 17.0.0-dev-9

Build #: 43318

Build Date: 2015-Apr-02 06:33:20 PM

Works fine in Version: 17.0.0-dev-8

Build #: 43300

Build Date: 2015-Apr-02 08:55:28 AM

5 attachments

GitFileBrowser-Status-Bug.png

2016-08-18T18:12:00Z

146 KB
git status bug.png

2016-08-19T11:52:41Z

18 KB
Screen Shot 2016-08-19 at 8.39.15 AM.png

2016-08-19T15:39:41Z

11 KB
14633.png

2016-08-23T12:09:10Z

64 KB
14633_v18.png

2016-08-23T12:18:19Z

65 KB

All Comments (5) Change History

SachinPrakash 2016-08-18T18:23:03Z

We upgraded to JGit version 3.7.0.201502260915-r in dev-9 build.

abdullah 2016-08-19T11:53:02Z · (edited)

Update: Looks like we are not showing the status icon for files under a sub-folder or a sub-folder hierarchy. Files which are direct children of the root folder shows the status icon correctly.

abdullah 2016-08-19T12:25:07Z

Root cause: The jGit api we were using to check file status was deprecated and was throwing exception.

Fix is to use the new WorkingTreeIterator > isModified(DirCacheEntry, boolean, ObjectReader) api. The fix is available in v17 Branch and US Trunk.

tariqrahiman 2016-08-19T15:39:57Z

This is now resolved in ADS v17.0.7-14

dutondeumesh 2016-08-23T12:18:56Z · (edited)

Verified in ADS-17.0.8 and ADS 18.0.0-devi-207

Search Tips

Aqua Data Studio / nhilam

GIT File Browser Status Bug - Modified Files does not get displayed in red color

5 attachments

Issue #14633

Completion

Search Tips

Aqua Data Studio / nhilam

Title

GIT File Browser Status Bug - Modified Files does not get displayed in red color

5 attachments

Issue #14633

Completion