@asif: Josh has checked-in changes for this in ADS v17 w/ svn# 51855.

Pls code review the options related changes which were made by Tom. Discuss w/ @tom for any changes.

In addition, code review Legend.java line #236 where a split is being on "\n". Does our property editor guarantee that newlines will always be "\n"? Or do we have to consider "\r\n"?

@asif: for v18, we're continuing to use the v17 property dialog in ADS charts. Hence, we will make the same change in v18 as well. For v19,  you should log an issue for enhancing the new v18 property dialog in File > Options to support the multi line functionality.

ADS v17 w/ svn# 51855.

Here is the feedback:

1) We should be using Multiline editor (MultilineStringCellEditor) instead of String array editor.

2) Change title to "Enter Multi-line Text"

3) While splitting the string we should be using a regex which accommodates both \r and \n, Eg: String.split("\\r?\\n") 

I am going to take a pass at this and will re-assign to Josh.

US Trunk SVN r51869: addressed the items posted here. Also addressed the issue of value typed in the property table directly is not reflected in the editor.

Note: the editor title says "Type in a multi line string"; Since it is coming from the component we use I left it as is.

1. Reset button is not working

2. The buffer is not cleared. If user enters a 1 line chart title and then click OK and then again click on the right drop down arrow, a new window with Type in a string array comes up. This does not contain the original text.

3. Script to New Window is incorrect and Chart Title position is not getting saved.

Adding more details to VA# 7008

1. Reset button is not working

2. The buffer is not cleared. If user enters a 1 line chart title and then click OK and then again click on the right drop down arrow, a new window with Type in a string array comes up. This does not contain the original text.

The above issues are addressed as part of US Trunk SVN r51869.

Scenario #3.

Add a multi line Chart Title and set Chart Title Position Top Left.

Right click inside grid and then Select Script Full to New Window and on the new window execute the Chart

You can see that the Chart Title is at the Bottom which is incorrect

3. Script to New Window is incorrect and Chart Title position is not getting saved.

@josh: Please take a look at this scenario.

@asif: chartproperty Title is multiline in editor so second line of title being parsed as property rather than Title Position.  Would you suggest addressing this in the parser itself? 

Scenario 3 fixed.  Editor supports multiline properties. svn 51879.

I'll kick-off a new build.

@asif: pls do another round of code review.

@josh & @tom: ensure changes are applied to v18 as well.

Verified in ADS v17.0.10-7. There was 1 issue which Tom had shown to me in Win machine. I was not able to reproduce it. @tom: please reopen if you can reproduce the issue consistently

I added two screen shots. Notice how the title text gets scrunched in the chart title field after entry..

Notice how the title text gets scrunched in the chart title field after entry..

I have seen this issue but it was a very minor UI issue that was not sure whether we wanted to address it or not.

US trunk SVN r51898: Fixed the issue of property table not showing spaces were new line appears.

svn 51879.

Changes look good.

Hi Asif,  Looks good now.. Thanks for tweaking it, Tom

@tom, I will make changes and update 18.

Verified all scenarios in OSX and windows in 17.0.10-8