|
207 KB
|
86 KB
|
196 KB
@ivan: only address issue if there is a low cost fix available.
I have tried to reproduce this issue from source and from the latest builds on windows and linux but am unable to reproduce.
@Tariq & Sachin: Can either of you guys reproduce this issue?
I have tried to reproduce this issue from source and from the latest builds on windows and linux but am unable to reproduce.
@Tariq & Sachin: Can either of you guys reproduce this issue?
@narendravatsaraj:
Thank you for the ogv file, that helps to make an attempt to follow the steps. I have tried your steps and am still unable to reproduce the issue. if you open up your Help-> SQL Log & View Log while you are doing this, do you see any exceptions been thrown? queries failing?
@narendravatsaraj:
Thank you for the ogv file, that helps to make an attempt to follow the steps. I have tried your steps and am still unable to reproduce the issue. if you open up your Help-> SQL Log & View Log while you are doing this, do you see any exceptions been thrown? queries failing?
Launch Create synonym UI on Master( 2nd in Database node list) SELECT name FROM sys.databases WHERE has_dbaccess(name) = 1 ORDER BY name --------------------------- SELECT name FROM [master].sys.schemas ---------------------------- SELECT name FROM [master].sys.schemas ------------------------------ SELECT SYSTEM_USER AS 'Login Name', CURRENT_USER as 'Current User'
Remove contents from the Server box and click inside Database box
SELECT name FROM [master].sys.schemas
First DB in list, launch Create synonym UI
SELECT name FROM sys.databases WHERE has_dbaccess(name) = 1 ORDER BY name -------------------------- SELECT name FROM [Diksha].sys.schemas -------------------------- SELECT name FROM [Diksha].sys.schemas -------------------------- SELECT SYSTEM_USER AS 'Login Name', CURRENT_USER as 'Current User'
After Removing contents from the Server box,
Just like above DB, below query is not executed.
select name from [Database name].sys.schemas
Pls check at your end. No exception in view log.
Launch Create synonym UI on Master( 2nd in Database node list) SELECT name FROM sys.databases WHERE has_dbaccess(name) = 1 ORDER BY name --------------------------- SELECT name FROM [master].sys.schemas ---------------------------- SELECT name FROM [master].sys.schemas ------------------------------ SELECT SYSTEM_USER AS 'Login Name', CURRENT_USER as 'Current User'
Remove contents from the Server box and click inside Database box
SELECT name FROM [master].sys.schemas
First DB in list, launch Create synonym UI
SELECT name FROM sys.databases WHERE has_dbaccess(name) = 1 ORDER BY name -------------------------- SELECT name FROM [Diksha].sys.schemas -------------------------- SELECT name FROM [Diksha].sys.schemas -------------------------- SELECT SYSTEM_USER AS 'Login Name', CURRENT_USER as 'Current User'
After Removing contents from the Server box,
Just like above DB, below query is not executed.
select name from [Database name].sys.schemas
Pls check at your end. No exception in view log.
The listener for the server was firing and filling the databases back into the combo box. If you where doing this on the first database in the list, after the combo box was reloaded its listener did not fire as the first database was already selected and does not change when database is set. To fix this, the server listener will also refill the schema list with the database list. This will that even if the database does not change, all combo boxes will correctly be reloaded.
Committed revision: 52123
The listener for the server was firing and filling the databases back into the combo box. If you where doing this on the first database in the list, after the combo box was reloaded its listener did not fire as the first database was already selected and does not change when database is set. To fix this, the server listener will also refill the schema list with the database list. This will that even if the database does not change, all combo boxes will correctly be reloaded.
Committed revision: 52123
@ivan,
My original mentioned issue is resolved now.
While verifying , found one more behaviour,
When we launch Create Synonym UI, "db_acceassadmin" schema is default selection in schema drop down.
But when ADS is repopulating schema drop down after removing contents from Server box, it sets default schema as "dbo". I think, here ADS should repopulate schema drop down with "db_accessadmin" schema.
see attached screenshot
@ivan,
My original mentioned issue is resolved now.
While verifying , found one more behaviour,
When we launch Create Synonym UI, "db_acceassadmin" schema is default selection in schema drop down.
But when ADS is repopulating schema drop down after removing contents from Server box, it sets default schema as "dbo". I think, here ADS should repopulate schema drop down with "db_accessadmin" schema.
see attached screenshot
When we add a server name we will record the current database and schema selection in the drop downs. If the server name is removed we will set the database and schema selection back to there previous state. If for some reason that database or schema no longer exists, then the first item in the drop down will be selected.
Committed revision: 52209
When we add a server name we will record the current database and schema selection in the drop downs. If the server name is removed we will set the database and schema selection back to there previous state. If for some reason that database or schema no longer exists, then the first item in the drop down will be selected.
Committed revision: 52209
@ivan,
----When we add a server name we will record the current database and schema selection in the drop downs. If the server name is removed we will set the database and schema selection back to there previous state.
I am able to verify this statement using four scenarios in build Beta 29
1. Do not change DB / schema in Create Synonym UI
Observation :
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
2. Change only DB name
In create synonym change default db name(select another db name from drop down list just below Server Box), keep schema unchanged.
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
3. Change only schema name
In create synonym change default schema name(select another schema name from drop down list just below Server Box), keep db name unchanged.
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
4.Change both db name / schema name.
In create synonym change default db name /schema name (select another db / schema name from drop down list just below Server Box)
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
--------------------------------------------------------------------------------------------------------------------------------------------------------
-----If for some reason that database or schema no longer exists, then the first item in the drop down will be selected.
I tried to verify this with two scenarios.
1. Delete selected DB name before removing Contents from Server box and observe db list.
2. Delete selected Schema name before removing contents from Server box and observe schema list.
In both scenarios we can still see dropped db name and schema name in drop down after removing contents from Server Box. (see attached screenshot)
@ivan,
----When we add a server name we will record the current database and schema selection in the drop downs. If the server name is removed we will set the database and schema selection back to there previous state.
I am able to verify this statement using four scenarios in build Beta 29
1. Do not change DB / schema in Create Synonym UI
Observation :
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
2. Change only DB name
In create synonym change default db name(select another db name from drop down list just below Server Box), keep schema unchanged.
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
3. Change only schema name
In create synonym change default schema name(select another schema name from drop down list just below Server Box), keep db name unchanged.
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
4.Change both db name / schema name.
In create synonym change default db name /schema name (select another db / schema name from drop down list just below Server Box)
As we enter contents in Server Box, db/schema list becomes empty.
As we remove contents in server box, db /schema repopulate with previous db and schema name successfully.
--------------------------------------------------------------------------------------------------------------------------------------------------------
-----If for some reason that database or schema no longer exists, then the first item in the drop down will be selected.
I tried to verify this with two scenarios.
1. Delete selected DB name before removing Contents from Server box and observe db list.
2. Delete selected Schema name before removing contents from Server box and observe schema list.
In both scenarios we can still see dropped db name and schema name in drop down after removing contents from Server Box. (see attached screenshot)
When we enter information into the Server box, the currently selected database and schema is recorded. If you then externally delete the database that was previously selected and then go back to the synonym dialog and remove the server name, when focus is lost the database list is repopulated with the database list. This database list is not extracted from live data but we stored it on dialog load. The list is then set to the previously selected database, which no longer exist. When this selection occurs, we do attempt to extract the information from the database for the schema list. Here you will see a sql executed in the sql log that fails. This is because the database no longer exists and so the schema box will only get populated with 'dbo'. So in the case that the database no longer list, the database itself will still be set to the previously selected, even though it doesn't exist anymore but the schema will be set to 'dbo'.
This situation should rarely happen and I think this behavior is acceptable behavior. I don't think this scenario will ever take place in a production environment.
When we enter information into the Server box, the currently selected database and schema is recorded. If you then externally delete the database that was previously selected and then go back to the synonym dialog and remove the server name, when focus is lost the database list is repopulated with the database list. This database list is not extracted from live data but we stored it on dialog load. The list is then set to the previously selected database, which no longer exist. When this selection occurs, we do attempt to extract the information from the database for the schema list. Here you will see a sql executed in the sql log that fails. This is because the database no longer exists and so the schema box will only get populated with 'dbo'. So in the case that the database no longer list, the database itself will still be set to the previously selected, even though it doesn't exist anymore but the schema will be set to 'dbo'.
This situation should rarely happen and I think this behavior is acceptable behavior. I don't think this scenario will ever take place in a production environment.
Issue #14849 |
Closed |
Fixed |
Resolved |
Completion |
No due date |
Fixed Build v18.0.0-beta-23 |
No time estimate |
1 issue link |
relates to #14021
Issue #14021Add Server Name to Synonym visual editing GUI in SQL Server as SSMS |
@ivan: only address issue if there is a low cost fix available.