Easily find issues by searching: #<Issue ID>
Example: #1832
Easily find members by searching in: <username>, <first name> and <last name>.
Example: Search smith, will return results smith and adamsmith
| Dev |
|
| QA | abhishekj(*) |
| Priority | Major |
| Complexity | Unknown |
| Component | Tools - Compare - Schema |
| Version | 18.0 |
|
|
203 KB
|
2 KB
|
|
129 B
|
|
120 KB
|
|
89 KB
|
|
159 KB
|
|
123 KB
|
|
45 KB
|
|
182 KB
For scenario 1:
1. As far as I can tell, when either the source or target schema is empty, the diff count is set to 1 (without doing an actual comparison). This seems to occur back in v17 (or even v16, see SDiffDatabase#merge).
2. As to why 2 differences are reported, this seems to be the way the code in com.intellij.diff.comparison package produce (specifically, in the ChangeCorrector.SmartLineChangeCorrector method). See attached screenshot when I use IntelliJ 14 to compare the contents).
3. To sync up the schema row diff count and diff UI count, instead of setting the diff count to 1, we could call SDiffDatabase#countDifferences
For scenario 2:
Either the source or target has \r characters embedded. When calculating the diff count, schema compare did not strip out the \r characters but when the content is set to the diff UI editors, the \r characters are removed - this explains why the schema row count is different from the diff UI's count.
Verified in ADS v18.0.1-5. Both scenarios are now fixed.
QA: please do regression on Schema Compare
Verified in ADS v18.0.1-5. Both scenarios are now fixed.
QA: please do regression on Schema Compare
Verified in ADS v18.0.1-8
@abhishek: we can go over scenario 1 in a google hangout and I can explain how i am able to reproduce it.
Verified in ADS v18.0.1-8
@abhishek: we can go over scenario 1 in a google hangout and I can explain how i am able to reproduce it.
Issue #15049 |
| Closed |
| Fixed |
| Resolved |
Completion |
| No due date |
| Fixed Build 18.0.1-5 |
| No time estimate |
For scenario 1:
1. As far as I can tell, when either the source or target schema is empty, the diff count is set to 1 (without doing an actual comparison). This seems to occur back in v17 (or even v16, see SDiffDatabase#merge).
2. As to why 2 differences are reported, this seems to be the way the code in com.intellij.diff.comparison package produce (specifically, in the ChangeCorrector.SmartLineChangeCorrector method). See attached screenshot when I use IntelliJ 14 to compare the contents).
3. To sync up the schema row diff count and diff UI count, instead of setting the diff count to 1, we could call SDiffDatabase#countDifferences
For scenario 2:
Either the source or target has \r characters embedded. When calculating the diff count, schema compare did not strip out the \r characters but when the content is set to the diff UI editors, the \r characters are removed - this explains why the schema row count is different from the diff UI's count.