@piotrod: we'll look into this further today & provide you an update.

@funfun: lets discuss later today.

I was able to reproduce the issue in ADS v18.0

There are 2 ways you can cancel a Schema Compare operation. One is select the 2 Schemas to be compared, select the Schema Objects and click on the Compare button. In the Schema Compare Results window, you have a Cancel button and when user hits Cancel - A cancel operation with 3 buttons No, New Compare and Yes is displayed. This works fine in both ADS v17 and ADS v18

Next way to cancel a Schema Compare is to run the operation to completion and the results come up. Next hit the Refresh button, a new compare starts and hit on Cancel and with ADS v18.0 the cancel operation has only 2 buttons No and Yes. In ADS v17 there are No, New Compare and Yes.

With a new compare the DB Object selection which the user had previously selected is preserved and user can add/modify the DB Objects for the compare. The Source and Target DB of the previous operation is also preserved.

See attached screenshots

Correct the "new compare" button is missing in ADS v18 when canceling a schema compare in the 2nd way (after the initial results are displayed and then refreshed)

The "New Compare" button was removed from the confirmation dialog by VA #6699 if progress panel is triggered from Refresh action. See VA #6699 for details.

The reason ADS does not offer "New Compare" in this scenario anymore is because the information presented in Schema Compare Results panel (these schema objects are cached in memory) could be out of date.

When Refresh is performed, ADS tries to sync up schema objects cached in memory against those stored in DB server. If user canceled the refresh operation, then there is no guarantee that schema objects cached in memory are up to date. If "New Compare" is offered in this scenario, then "Schema Compare Tool" dialog will be presented with schema objects cached in memory and these objects may be out of date; if any of presented object is out of date (e.g. does not exist in server), then an error will be reported after user clicks the Compare button in Schema Compare Tool dialog.

 it would be even nicer if this button was put next to the refresh button on the compare results toolbar.  

@piotrod: In ADS v18, we will add a button next to the refresh button on the compare results toolbar which will do the equivalent of the "New Compare" button in ADS v17. We should have a patch available this week with this change.

Hi Sachin,

I added a new button next to the Refresh button followed by a separator on the toolbar, please see the first set of screenshots in this attachment.

We currently need to remove the "Schema Compare Results" panel on which "Edit Compare" is performed (this behavior is also true in v17 when "New Compare" is performed). We will display the following confirmation message:

The "Schema Compare Results" panel will be removed in order to perform "Edit Compare" operation. Do you want to continue?

Please see the second set of screenshots in this attachment.

Please review above behavior/tooltip/message and let me know if anything needs to be changed.

@fung: looks good. Go ahead & check-in.

Done: SVN r53522/ADS 18.0.4-1

I also modified standalone program. Because standalone program does not support removing "Schema Compare Results" panel, hence, I disabled "Edit Compare" button in standalone program at the moment. By the way, the new icon file is "app_actions/menu_edit_compare.png".

@QA:

As described here, "Edit Compare" might generate errors if data cached in memory is out of date. This attachment demonstrates the data-out-of-date problem using a simple scenario. To avoid the problem, user needs to perform a "Refresh" to make in-memory data up-to-date before performing "Edit Compare".

The new button didn't appear when I applied the patch

see attached screenshot

@piotrod: this feature is still under development & is not yet available in a patch. Once the feature is ready, I'll post the patch link & instructions for you to download & try it out.

@nileshhmali:

Regarding questions you asked here:

Can we provide "[Error generating DDL]" icon similar to schema sync?

"Schmea Compare Results" panel created by "Schema Compare Tool" dialog currently does not provide a way to visually indicate objects in invalid state. I have logged a separate enhancement request for this, see ADS #15081.

Scenario-01-With object dependacy(e.g Table depend on UDT)

The NPE generated by this scenario has something to do with scripting. I have logged a separate issue, ADS #15080, to address this problem.

Scenario-02(Without object dependacy)

The exception "java.lang.Exception: [test_c2] table data not found in system catalog!" is intentionally logged in this scenario, there is nothing wrong here.

@piotrod: The "Edit Compare" action has been added in the below patch.

Verified in ADS-18.0.4-6

Edit Compare option is available in schema  compare result tab for schema sync and Schema Compare

Please refer screenshot
Schema sync
Schema compare 

Verified in ADS v18.0.5-6