#15172: Editor Tabs: Bold the tab title

SachinPrakash reported 2017-04-19T03:58:14Z · last modified 2017-04-19T21:18:58Z

Editor Tabs: Bold the tab title

Dev	kin-hong
QA	tariqrahiman

Priority	Low
Complexity	Unknown

Component	Editor
Version	18.0

In ADS v17, we bolded the text in the active tab. We no longer do this. Can you look at our new tab code & add back the "bolding" of the text in the active tab. Pls make this change in ADS v18 & v19. See attached screenshot for v17 vs current v18/v19 behavior.

4 attachments

TabTitle.png

2017-04-19T03:58:14Z

51 KB
Screen Shot 2017-04-19 at 10.21.47 am.png

2017-04-19T17:21:43Z

54 KB
Screen Shot 2017-04-19 at 10.45.34 am.png

2017-04-19T17:44:48Z

78 KB
Screen Shot 2017-04-19 at 12.15.59 pm.png

2017-04-19T19:43:46Z

91 KB

All Comments (3) Change History

kin-hong 2017-04-19T04:40:13Z

In v17, the method DocumentPane#activateGroup will check for the UIDefaults property "DocumentPane.boldActiveTab" and if it is TRUE then DocumentPane will manage active tab boldness amongst document groups (only one tab can be active/bold amongst all groups).

For OSX, the "DocumentPane.boldActiveTab" property is installed during LookAndFeelFactory#installJideExtension when the com.jidesoft.plaf.aqua.AquaJideUtils#initComponentDefaults method is executed.

In v18, we have a similar startup sequence. However when com.jidesoft.plaf.aqua.AquaJideUtils#initComponentDefaults is invoked, it does not detect the presence of Jide's PRODUCE_COMPONENTS - this causes AquaJideUtils#initComponentDefaults to not install UIDefaults related to Jide documents (where "DocumentPane.boldActiveTab" is grouped under). This is due to the fact that we removed the jide-components.jar in v18.

For Windows and Linux, the same scenario applies to "DocumentPane.boldActiveTab" not being set during corresponding (depending on L&F) xxxxxUtils#initComponentDefaults methods because the PRODUCE_COMPONENTS/jide-components.jar has been removed.

I fixed this by setting the "DocumentPane.boldActiveTab" UIDefaults property to always TRUE in CLookAndFeel. Due to this change, I also needed to fix a NPE in TabDocumentPane.

SachinPrakash 2017-04-19T05:09:31Z

@qa: this will need to be tested on all 3 OSes.

tariqrahiman 2017-04-19T21:18:58Z · (edited)

Verified in ADS v18.0.9-3 - in all OS. Multiple Tab Colors also work fine with the fix

Search Tips

Aqua Data Studio / nhilam

Editor Tabs: Bold the tab title

4 attachments

Issue #15172

Completion

Search Tips

Aqua Data Studio / nhilam

Title

Editor Tabs: Bold the tab title

4 attachments

Issue #15172

Completion