Easily find issues by searching: #<Issue ID>
Example: #1832
Easily find members by searching in: <username>, <first name> and <last name>.
Example: Search smith, will return results smith and adamsmith
| Dev |
|
| QA |
|
| Priority | Low |
| Complexity | Unknown |
| Component | Tools - Compare - Schema |
| Version | Future - PM |
| Behaviour in different ADS Builds | Filter behaviour in Schema Compare. |
| ADS 19 alpha-10 | Y |
| ADS v18 | Y |
| ADS v17 | N |
| Y :- Issue is reproducible | |
| N :- Issue is not reproducible | |
|
|
434 KB
|
|
186 KB
@tom: the desired behavior is that the filter should be intact. The filter _should not_ get removed. Only make this change if low impact.
@tom: the desired behavior is that the filter should be intact. The filter _should not_ get removed. Only make this change if low impact.
Hi Sachin,
For me the behavior is consistent when clicking the "Edit Compare" button for both the "Type of difference" and the "No group" menu's. In both cases the selected types are reset and the state filter is persisted. With refresh, the filter object is persisted in the SchemaDiffResultsPanel and so never gets removed. The SchemaSyncPanel references that filter object when it is rebuilt. With edit compare, the SchemaDiffResultsPanel is rebuilt thereby removing the filter object referenced by the SchemaSyncPanel. Also, it looks like the data model is rebuilt since the data can be different. The attached filter object in the data model is also rebuilt.
The state filter selections for the no groups panel are persisted to disk and added to any new filter objects that are built. That is why in scenario 2 the filter continues to be applied after restart.
It is easy to use properties to persist the state filter since it never changes. I'm guessing in the case of the type filter, since it is dynamic, it is was never persisted.
I think we will have to add this persistence in to maintain the complete filter settings. Not really a low impact change since the filter is used in a lot a places and will have to be tested.
What do you think?
Thanks, Tom
Hi Sachin,
For me the behavior is consistent when clicking the "Edit Compare" button for both the "Type of difference" and the "No group" menu's. In both cases the selected types are reset and the state filter is persisted. With refresh, the filter object is persisted in the SchemaDiffResultsPanel and so never gets removed. The SchemaSyncPanel references that filter object when it is rebuilt. With edit compare, the SchemaDiffResultsPanel is rebuilt thereby removing the filter object referenced by the SchemaSyncPanel. Also, it looks like the data model is rebuilt since the data can be different. The attached filter object in the data model is also rebuilt.
The state filter selections for the no groups panel are persisted to disk and added to any new filter objects that are built. That is why in scenario 2 the filter continues to be applied after restart.
It is easy to use properties to persist the state filter since it never changes. I'm guessing in the case of the type filter, since it is dynamic, it is was never persisted.
I think we will have to add this persistence in to maintain the complete filter settings. Not really a low impact change since the filter is used in a lot a places and will have to be tested.
What do you think?
Thanks, Tom
Issue #15262 |
| In Progress |
Completion |
| No due date |
| No fixed build |
| No time estimate |