Nhi,

     We have added 'Create separate tab for SQL Query' Text for checkbox. We have added this text into 'master.prompt.csv' file. For fetching this value we used code as

TXT.get("ExportDialog.CheckBox-IncludeQueryTab", "Create separate tab for SQL Query");

For this we are having following questions :

• Now after executing code each time its fetching default value provided in code. Not fetching from properties value. After debuging code we get to know that, we are loading languages specific properties file in CONFIG_DIRECTORY. But in that directory we don't have any language specific properties file. So do we need configure anything to generate these laguage specific properties files into CONFIG_DIRECTORY.
• How translation of this newly added text will going to handle. 

Translation is handled as a separate effort, which is outside this issue. As long as you're doing TXT.get("some key that's unique across the entire code base", "English version of the string"), then you're fine. Just prepend the class name to the the unique key to avoid conflicting with keys in other classes.

This issue is verified on Build no.: ads-windows-x64-18.5.0-dev-8.

Code Review:

1. Revert all changes in master.prompts.csv. This is an automatically generated file.
2. The Aqua Script related changes are incorrect. The CoreExcelWriter is a generic API that write Excel files, including adding new worksheets. Thus there is no need to make any Open API changes.
   • Revert all Open API and Aqua Script related code changes.
   • When generating the Aqua Script in GenerateExportAquaScript, add the following Aqua Script statements right before the "wr.saveToFile(...);" call.
     • wr.setCurrentWorksheet("Query");
     • wr.write(actual query);
3. The ETLExcelOutput is a generic class that writes Excel files. The code changes are incorrect and clouds the API of this class.
   • Revert all changes in this class.
   • The special logic that writes the query in a new tab should be completely in the export code, not the generic Excel code. For example, the ExportThread should invoke the ETLExcelOutput.addWorkSheet("Query") and ETLExcelOutput.write(actual query) to write the query in a new tab.
   • Expose a new addWorkSheet(worksheetName) method in ETLExcelOutput to add a new tab. This is a generally useful method not specific to export.

1. Revert all changes in master.prompts.csv. This is an automatically generated file. --> SZ : Fixed
2. The Aqua Script related changes are incorrect. The CoreExcelWriter is a generic API that write Excel files, including adding new worksheets. Thus there is no need to make any Open API changes. --> SZ : Fixed
   • Revert all Open API and Aqua Script related code changes.
   • When generating the Aqua Script in GenerateExportAquaScript, add the following Aqua Script statements right before the "wr.saveToFile(...);" call.
     • wr.setCurrentWorksheet("Query");
     • wr.write(actual query);
3. The ETLExcelOutput is a generic class that writes Excel files. The code changes are incorrect and clouds the API of this class.--> SZ : Fixed
   • Revert all changes in this class.
   • The special logic that writes the query in a new tab should be completely in the export code, not the generic Excel code. For example, the ExportThread should invoke the ETLExcelOutput.addWorkSheet("Query") and ETLExcelOutput.write(actual query) to write the query in a new tab.
   • Expose a new addWorkSheet(worksheetName) method in ETLExcelOutput to add a new tab. This is a generally useful method not specific to export.

[Nhi] Looks fine.

A couple issues that we should have taken care of but can be pushed to a future release. 

1) The new checkbox in the gui should have a property attached to it instead of always being set to on at export initiialization.  

2) This feature should have also been added to the Fliudshell export. CoreLibExportThread.

3) Maybe we should have added this to the Aquascript export project?