I suggest to rename methods to macth their descriptions
void
setRenderHtmlDocFooter(boolean flag)
Determines whether to generate the closing tags for the html
tag and the body
tag; these tags are not generated by default.
void
setRenderHtmlDocHeader(boolean flag)
Determines whether to generate the opening tags for the html
tag and the body
tag; these tags are not generated by default.
Fung,
I'd suggest renaming as follows:
isRenderHtmlDocFooter() ==> isGenerateHtmlAndBodyCloseTags()
isRenderHtmlDocHeader() ==> isGenerateHtmlAndBodyOpenTags()
setRenderHtmlDocFooter() ==> setGenerateHtmlAndBodyCloseTags(boolean flag)
setRenderHtmlDocHeader() ==> setGenerateHtmlAndBodyOpenTags(boolean flag)
Fung - here is the revised version, as discussed w/ Niels:
I'd suggest renaming as follows (swapping Render w/ Generate)
isRenderHtmlDocFooter() ==> isGenerateDocFooter()
isRenderHtmlDocHeader() ==> isGenerateHtmlDocHeader()
setRenderHtmlDocFooter() ==> setGenerateHtmlDocFooter(boolean flag)
setRenderHtmlDocHeader() ==> setGenerateHtmlDocHeader(boolean flag)
Fung - here is the revised version, as discussed w/ Niels:
I'd suggest renaming as follows (swapping Render w/ Generate)
isRenderHtmlDocFooter() ==> isGenerateDocFooter()
isRenderHtmlDocHeader() ==> isGenerateHtmlDocHeader()
setRenderHtmlDocFooter() ==> setGenerateHtmlDocFooter(boolean flag)
setRenderHtmlDocHeader() ==> setGenerateHtmlDocHeader(boolean flag)
Made changes per suggested names:
. renamed isRenderHtmlDocXXX() to isGenerateHtmlDocXXX(),
. renamed setRenderHtmlDocXXX() to setGenerateHtmlDocXXX().
Sending src-rep\src\lib\aqua-core\com\aquafold\aquacore\open\report\CoreReport.java
Sending src-rep\src\lib\aqua-core\com\aquafold\aquacore\open\report\CoreReportSettings.java
Sending src-rep\src\lib\aqua-open\com\aquafold\openapi\report\AQReportSettings.java
Transmitting file data ...
Committed revision 14785.
Unit test scripts are updated as well:
Sending aqua-projects\Aqua OpenAPI\Report\AquaScripts\Examples\unitTestDataSet.xjs
Sending aqua-projects\Aqua OpenAPI\Report\AquaScripts\Examples\unitTestPivotReport.xjs
Transmitting file data ..
Committed revision 4791.
Made changes per suggested names:
. renamed isRenderHtmlDocXXX() to isGenerateHtmlDocXXX(),
. renamed setRenderHtmlDocXXX() to setGenerateHtmlDocXXX().
Sending src-rep\src\lib\aqua-core\com\aquafold\aquacore\open\report\CoreReport.java
Sending src-rep\src\lib\aqua-core\com\aquafold\aquacore\open\report\CoreReportSettings.java
Sending src-rep\src\lib\aqua-open\com\aquafold\openapi\report\AQReportSettings.java
Transmitting file data ...
Committed revision 14785.
Unit test scripts are updated as well:
Sending aqua-projects\Aqua OpenAPI\Report\AquaScripts\Examples\unitTestDataSet.xjs
Sending aqua-projects\Aqua OpenAPI\Report\AquaScripts\Examples\unitTestPivotReport.xjs
Transmitting file data ..
Committed revision 4791.
Issue #4274 |
Closed |
Fixed |
Resolved |
Completion |
No due date |
No fixed build |
No time estimate |
Fung,
I'd suggest renaming as follows:
isRenderHtmlDocFooter() ==> isGenerateHtmlAndBodyCloseTags()
isRenderHtmlDocHeader() ==> isGenerateHtmlAndBodyOpenTags()
setRenderHtmlDocFooter() ==> setGenerateHtmlAndBodyCloseTags(boolean flag)
setRenderHtmlDocHeader() ==> setGenerateHtmlAndBodyOpenTags(boolean flag)