Easily find issues by searching: #<Issue ID>
Example: #1832
Easily find members by searching in: <username>, <first name> and <last name>.
Example: Search smith, will return results smith and adamsmith
Version: 12.0.0-alpha-16
Build #: 28618
Build Date: 2012-Aug-07 01:26:50 PMOperating Environment: Linux (3.2.0-27-generic, amd64) / UTF-8 / en / US / Oracle Corporation 1.7.0_05-b06
Memory: Max=3,819,634,688; Total=763,166,720; Free=304,661,216; CPUs=8
Format Scripts dialog doesnt popup after you change Formatter options ( no focus on tabs after file options is closed )
To reproduce:
1.) Change any of the Formatter option chechboxes (Before Comma or After comma) and click ok
2,) Without clicking inside the Editor, right click and select Format Script
Nothing happens and no dialog is displayed
Check the behaviour with ADS 11.0 and you can see that it is not the way it used to work
CASE #2 from jonathan
1. open an editor, type a query
2. use the keyboard shortcut to launch the Options dialog ( ctrl + , )
3. press the cancel button on the options dialog
4. right click in the schema browser on a connection and choose "unregister server"...
either a): nothing happens or b) if you had previously selected something in the Files tab, you get a prompt asking if you want to delete the selected item from the files tab ( even though your right click menu was accurate for the schema browser ).
see attached animations and screenshots.
Correct behavior for v12 should be what occurs in v11.
1. after the option dialog goes away, right click on an item inside the server tab should give the server tab focus and the item you right click focus. If it's an editor you right click inside of, the Editor should get focus.
Neither of these issues have to do with options. They are query analyzer issues. For some reason when you right click after losing focus you will notice that the action doesn't process.
BaseSQLKit..java, actionPerformed() at line 249 never executes an action...
Neither of these issues have to do with options. They are query analyzer issues. For some reason when you right click after losing focus you will notice that the action doesn't process.
BaseSQLKit..java, actionPerformed() at line 249 never executes an action...
When we call EditorPreferences.setAnnotationBarVisible("text/sql-mysql", true) with the mime string "text/sql-mysql" our ActionWrapper actionPerformed call routing stops working. I have tried couple different mime types and call routing continued to work ok.
Emilian, can you take a look.
When we call EditorPreferences.setAnnotationBarVisible("text/sql-mysql", true) with the mime string "text/sql-mysql" our ActionWrapper actionPerformed call routing stops working. I have tried couple different mime types and call routing continued to work ok.
Emilian, can you take a look.
I think this issue goes beyond the Vincaed editors.
Regarding the right-click behaviour when window of interest isn't focused yet (i.e. there was no left-click on it): I've noticed that on ADS v11 builds, right-clicking on any JIDE tab (its content area) gives focus to that container (e.g. open a FluidShell window and then right-click on Servers tab). This is no more true with ADS v12 builds. Could it be caused by the newer JIDE library ?
I mean, on the older JIDE version (delivered on ADS v11 builds), the right-click event seems to be intercepted by JIDE and trigger tab focusing before passing this mouse event further to the target JComponent etc. With the newer JIDE version, only left-clicks trigger such a behaviour, while right-clicks doesn't influence the JIDE window manager.
I think this issue goes beyond the Vincaed editors.
Regarding the right-click behaviour when window of interest isn't focused yet (i.e. there was no left-click on it): I've noticed that on ADS v11 builds, right-clicking on any JIDE tab (its content area) gives focus to that container (e.g. open a FluidShell window and then right-click on Servers tab). This is no more true with ADS v12 builds. Could it be caused by the newer JIDE library ?
I mean, on the older JIDE version (delivered on ADS v11 builds), the right-click event seems to be intercepted by JIDE and trigger tab focusing before passing this mouse event further to the target JComponent etc. With the newer JIDE version, only left-clicks trigger such a behaviour, while right-clicks doesn't influence the JIDE window manager.
There are manu issues with new JIDE. But this case is interesting.
Here is the code fragment that causes this to happen:
There are manu issues with new JIDE. But this case is interesting.
Here is the code fragment that causes this to happen:
> our ActionWrapper actionPerformed call routing stops working
How exactly does it stop working? Does something become null? Or does org.netbeans.editor.BaseAction.actionPerformed just bail out early? (The later would probably mean the target component is wrong.)
I'll try tomorrow and see if I can duplicate it.
> our ActionWrapper actionPerformed call routing stops working
How exactly does it stop working? Does something become null? Or does org.netbeans.editor.BaseAction.actionPerformed just bail out early? (The later would probably mean the target component is wrong.)
I'll try tomorrow and see if I can duplicate it.
>It is never called after this.
But who calls ActionWrapper.actionPerformed? Why does it stop calling it?
>It is never called after this.
But who calls ActionWrapper.actionPerformed? Why does it stop calling it?
We have JComponent ActionMap with a bunch of ActionWrappers added to it.
In normal circumstances when the popup menu item is clicked Swing routes this call to the ActionMap which then routes it to org.netbeans.editor for QueryPanel.
Then BaseSQLKit actionPerformed is being called from netbeans.
After OptionDialog2 is closed with OK button the focus is never returned to netbeans editor.
I found that if I click on the editor everything starts working ok, so EditorPane does not get focus back.
Strange that if I filter out setAnnotationBarVisible for mysql mime it gets focus back.
So I will fix this issue with forcing the focus back to EditorPane.
We have JComponent ActionMap with a bunch of ActionWrappers added to it.
In normal circumstances when the popup menu item is clicked Swing routes this call to the ActionMap which then routes it to org.netbeans.editor for QueryPanel.
Then BaseSQLKit actionPerformed is being called from netbeans.
After OptionDialog2 is closed with OK button the focus is never returned to netbeans editor.
I found that if I click on the editor everything starts working ok, so EditorPane does not get focus back.
Strange that if I filter out setAnnotationBarVisible for mysql mime it gets focus back.
So I will fix this issue with forcing the focus back to EditorPane.
Larion,
>> Do you have any idea why it happens only for text/sql-mysql?
It only happens for text/sql-mysql for you, because you have a query window of text/sql-mysql open while testing. If you open a query window of text/sql-sqlserver, then the problem occurs. You are specifically commenting out the code that triggers a reset on the currently open window which is a MySQL query window. If you open a SQL Server query window and comment out text/sql-sqlserver, then it will not happen for text/sql-sqlserver.
Larion,
>> Do you have any idea why it happens only for text/sql-mysql?
It only happens for text/sql-mysql for you, because you have a query window of text/sql-mysql open while testing. If you open a query window of text/sql-sqlserver, then the problem occurs. You are specifically commenting out the code that triggers a reset on the currently open window which is a MySQL query window. If you open a SQL Server query window and comment out text/sql-sqlserver, then it will not happen for text/sql-sqlserver.
Issue #7387 |
| Closed |
| Incomplete |
| Resolved |
Completion |
| No due date |
| No fixed build |
| No time estimate |
Correct behavior for v12 should be what occurs in v11.
1. after the option dialog goes away, right click on an item inside the server tab should give the server tab focus and the item you right click focus. If it's an editor you right click inside of, the Editor should get focus.