Hi Emilian,

A question about SSH Terminal:

In Options dialog, "SSH Terminal -> General" tab, we have changed:
    Label: "History Buffer Size"
    Description: History Buffer Size
to
    Label: "Shell Buffer Size"
    Description: Determine the maximum number of text lines to be displayed in the shell window.

Can you please confirm whether this is correct?

If this is not correct, we need to change it back; then, does 'History Buffer Size' mean:
    "The maximum number of commands to remember in the command history." ?

Fluid terminal was using SSH terminal's property to do the following:
   Term.setHistorySize(int)
It is fixed now.

The javadoc of Term.setHistorySize(int) says:
   Set how many lines of history will be available.
Not sure what does this mean.

Both "FluidShell -> Text Buffer Size" and "SSH Terminal -> History Buffer Size" have been renamed to
   "Shell Buffer Size"
with the following description:
   "Determines the maximum number of text lines to be displayed in the shell window."
Is this a correct statement?  Probably not, please see my previous comment.


Property "FluidShell -> Statement History Size" has been renamed to "SQL History Size" which is "Determines the number of SQL statements to be kept in memory."  Try below in a fluid shell:
   prompt$ select 123
   prompt$ \go
   prompt$ \sqlhistory
then, a panel will be displayed at the bottom of the shell with all of SQL statements have been executed, up to the number defined by the "SQL History Size" property.

Both "FluidShell -> Text Buffer Size" and "SSH Terminal -> History Buffer Size" have been renamed to
   "Shell Buffer Size"
with the following description:
   "Determines the maximum number of text lines to be displayed in the shell window."
Is this a correct statement?  Probably not, please see my previous comment.

Actually, it represents the number of lines the scrollback can hold, i.e. the lines that are no more on the visible area (which has fixed size e.g. 80x24 cells etc depending on the FluidShell window size) but can go back on the visible area when changing vertical scrollbar's position.

e.g. If you set its value to "5" then start issuing commands on a new FluidShell window till it overflows visible area, you'll notice that only five out-of-screen lines are kept on the scrollback, while the others go away.

So History Buffer Size in lib.terminalemulator's parlance doesn't refer to the command history buffer (past issued commands), but the output lines that went out of the screen, but are still kept in order to make the scrollbar usable. This is also referred as "scrollback" but the term might be less intuitive.

I would change the description from
"Determines the maximum number of text lines to be displayed in the shell window."
to something like
"Determines the maximum number of text lines to be buffered by the shell window."
as it represents the number of lines buffered, or stored for scrolling back, and not the one displayed.

Additionally, there seems to be a regression introduced by the changes for this property.

A scenario to get the regression:
* have the Shell Buffer Size set, for instance, to 5
* have the ADStudio window maximized
* type, for instance, \declare multiple times until you get the scroll bar with the 5 lines buffer
* unmaximize the ADStudio window making its height smaller, for instance half of the screen size
* maximize the window back
Now if you scroll up the FluidShell prompt area becomes white.
 

> I would change the description from
> "Determines the maximum number of text lines to be displayed in the shell window."
> to something like
> "Determines the maximum number of text lines to be buffered by the shell window."
> as it represents the number of lines buffered, or stored for scrolling back, and not the one displayed.

I made change based on your suggestion. SVN r29205.

> Additionally, there seems to be a regression introduced by the changes for this property.
>
> A scenario to get the regression:
> * have the Shell Buffer Size set, for instance, to 5
> * have the ADStudio window maximized
> * type, for instance, \declare multiple times until you get the scroll bar with the 5 lines buffer
> * unmaximize the ADStudio window making its height smaller, for instance half of the screen size
> * maximize the window back
> Now if you scroll up the FluidShell prompt area becomes white.
 
Since I can reproduce the problem described above in SSH terminal by following exactly the same steps, I am assuming you will look into this.

In addition, in an SSH terminal, after the last step described above,
  > * maximize the window back
  # move scrollbar all the way down and then unmaximize the ADS window again
You will notice that the size of the scrollbar handle becomes much smaller than it should be (this does not happen all the time, once in a while).
  # type a command, followed by <Enter>
The scrollbar now is displayed correctly.

Please try scenario below and see if it also occurs on your end:
(1) launch ADS
(2) set "File -> Options -> SSH Terminal -> Shell Buffer Size" to a small number, e.g. 3
(3) set ADS window size to half of the monitor size
(4) open a SSH terminal tab
(5) repeat typing '\declare a=1'<Enter> until scrollbar shows up
(6) move the handle of the scrollbar all the way up and let it stay there
(7) maximize the ADS window
After (7), I usually see a tab with white contents

In general, at step (6), if I moved scrollbar handle up (does not need to reach the top), then step (7) produces an undesired result.

>> In general, at step (6), if I moved scrollbar handle up (does not need to reach the top),
>> then step (7) produces an undesired result.

After updated to head of trunk, SVN r29265, this problem is not seen any more; neither SSH terminal, nor Fluid shell.

Verified using ADStudio 12 Beta 38, the problems described above do not appear any longer.

Closed.