Easily find issues by searching: #<Issue ID>
Example: #1832
Easily find members by searching in: <username>, <first name> and <last name>.
Example: Search smith, will return results smith and adamsmith
Reviewed ExtractTrigger and made change in ExtractTrigger.getTrigger() for both PostgreSQL and Greenplum (same implementation). Only tested Greenplum 4.2 and PostgreSQL 8.2. SVN r30611.
Notes:
(1) Based on source code, PostgreSQL 7.2 or older versions do not seem to support schema; the change made in r30611 will take care of this but I could not verify it because I don't have access to PostgreSQL 7.2 server.
(2) There are similar codes in ExtractTrigger.getTriggers() as well, but I did not modify them. ExtractTrigger.getTriggers() usually is called by Triggers Node which is not interested in trggier's source text; ExtractTrigger.getTriggers() is also called by 'Script Table Full', however, in this case, 'Script Trigger Full' will call ExtractTrigger.getTrigger() to get trigger source. In additon, all of 'trigger type' codes used in ExtractTrigger.getTriggers() seem to be out-of-date.
(3) In r30611, ExtractTrigger.getTrigger() did not apply 'object quote identifiers' to schema.table, because ExtractTrigger.getTrigger() did not do this for trigger name either.
Issue #8069 |
| Closed |
| Fixed |
| Resolved |
Completion |
| No due date |
| Fixed Build trunk/30611 |
| No time estimate |
Reviewed ExtractTrigger and made change in ExtractTrigger.getTrigger() for both PostgreSQL and Greenplum (same implementation). Only tested Greenplum 4.2 and PostgreSQL 8.2. SVN r30611.
Notes:
(1) Based on source code, PostgreSQL 7.2 or older versions do not seem to support schema; the change made in r30611 will take care of this but I could not verify it because I don't have access to PostgreSQL 7.2 server.
(2) There are similar codes in ExtractTrigger.getTriggers() as well, but I did not modify them. ExtractTrigger.getTriggers() usually is called by Triggers Node which is not interested in trggier's source text; ExtractTrigger.getTriggers() is also called by 'Script Table Full', however, in this case, 'Script Trigger Full' will call ExtractTrigger.getTrigger() to get trigger source. In additon, all of 'trigger type' codes used in ExtractTrigger.getTriggers() seem to be out-of-date.
(3) In r30611, ExtractTrigger.getTrigger() did not apply 'object quote identifiers' to schema.table, because ExtractTrigger.getTrigger() did not do this for trigger name either.