If I source a file w/ disconnect and connect, see the output below:
Disconnect request is not executed in the command thread; it is forwarded to shell via Swing EDT and executed in EDT. I guess the reason to handle the request in EDT is that shell needs to update the connection status displayed in the shell panel after the connection is closed.
Execution of the disconnect request in EDT causes the following problems:
(1) The disconnect request is not cancelable (because it is submitted to Swing EDT once request is received).
(2) Command(s) executed subsequently may run out of order (as described in this issue and issue #6904).
I made change so that command thread will wait until EDT finished execution to fix the problem (2) described above:
SVN r30963 - 12.0 branch
SVN r30970 - 13.0 branch
SVN r30971 - trunk
This change also works for #6904 as well.
There is nothing we can do for problem (1) based on the current ADS approach.
Verified using ADStudio 12.0.15-10, 13 RC 1 & ADS 14 Dev 8 on a similar scenario, problem (2) described above doesn't seem to occur.
Closed.
Verified using ADStudio 12.0.15-10, 13 RC 1 & ADS 14 Dev 8 on a similar scenario, problem (2) described above doesn't seem to occur.
Closed.
Issue #8191 |
Closed |
Fixed |
Resolved |
Completion |
No due date |
Fixed Build 12.0/r30963, 13.0/r30970, trunk/r30971 |
No time estimate |
3 issue links |
relates to #6922
Issue #6922\reconnect command gives exception in View Logs --> java.lang.Exception: This code must be invoked in EDT. |
relates to #7618
Issue #7618NPE on using the reconnect command and pipelining with session -c |
relates to #6904
Issue #6904\disconnect displays exception in CmdLine |
Disconnect request is not executed in the command thread; it is forwarded to shell via Swing EDT and executed in EDT. I guess the reason to handle the request in EDT is that shell needs to update the connection status displayed in the shell panel after the connection is closed.
Execution of the disconnect request in EDT causes the following problems:
(1) The disconnect request is not cancelable (because it is submitted to Swing EDT once request is received).
(2) Command(s) executed subsequently may run out of order (as described in this issue and issue #6904).
I made change so that command thread will wait until EDT finished execution to fix the problem (2) described above:
SVN r30963 - 12.0 branch
SVN r30970 - 13.0 branch
SVN r30971 - trunk
This change also works for #6904 as well.
There is nothing we can do for problem (1) based on the current ADS approach.