#8614: File -> "Open Recent" doesn't load the file inside of query analyzer

SachinPrakash reported 2013-04-05T17:48:25Z · last modified 2013-04-11T19:43:34Z

File -> "Open Recent" doesn't load the file inside of query analyzer

Dev	kin-hong
QA	nhilam

Priority	Major
Complexity	Unknown

Component	Q Analyzer
Version	13.0

In ADS v12, the behavior is as follows:

1) Open Query Analyzer

2) Load a file inside of Query Analyzer. Lets call the file "a.sql"

3) File -> Open Recent -> a.sql

4) A new Query Analyzer window is opened up with the file contents loaded

Repeat the above steps in ADS v13. Notice that in step 4, the file contents are not loaded -- this is the bug.

All Comments (3) Change History

swissarmyknife(*) 2013-04-05T18:31:35Z

first encountered in 13.0-alpha-1 Build #: 30570 Build Date: 2012-Dec-11 02:42:12 PM

bug not appearing in 13-dev-54 Build #: 30540 Build Date: 2012-Dec-10 11:28:11 AM

kin-hong 2013-04-11T17:50:28Z

1. Before this issue surfaces (as in ADS 12), QueryPanel's doOpen() method overrides parent class CEditorPanelView's doOpen() to open the file only after DB connection is successful in a different thread. This ensures the editor is initialized before the file is loaded

2. However, in r30545, CEditorPanelView was refactored with "Migrating usages of C<class> to itree interfaces". The method signature of doOpen() was changed from

public void doOpen(File file, CTreeNode node, String encoding)

public void doOpen(File file, ITreeNode node, String encoding)

But the subclass QueryPanel's doOpen() method's signature did not change from CTreeNode to ITreeNode, causing QueryPanel's doOpen() method to not override parent class's method anymore. This causes CEditorPanelView's openFile() method to execute right away, before the editor was initialized

tariqrahiman 2013-04-11T19:43:34Z

Verified in 13.0-rc-23

Search Tips

Aqua Data Studio / nhilam

File -> "Open Recent" doesn't load the file inside of query analyzer

Issue #8614

Completion

Search Tips

Aqua Data Studio / nhilam

Title

File -> "Open Recent" doesn't load the file inside of query analyzer

Issue #8614

Completion