When we compare objects that we do not supported DDL extraction for we will not be able to tell if they are different. Related to Issue #14342
|
56 KB
|
66 KB
|
96 KB
|
96 KB
@pranav: look at #14342 to detect this situation. If this situation is detected, can you put "Error" in the "Diff Count" column. We also put a different background color on the row to indicate error.
Hello Tom,
I have made changes as per above comment. see screenshot. I have checked in the changes with SVN r#11092.
@Sachin,
We also put a different background color on the row to indicate error.
Hello Tom,
I have made changes as per above comment. see screenshot. I have checked in the changes with SVN r#11092.
@Sachin,
We also put a different background color on the row to indicate error.
Hi Pranav,
For the method isUnsupportedDDLExtraction(), how about if you change the equals to startsWith like this?
return object != null && object.getCreateScript().startsWith(object.getBaseObject().UNSUPPORTED_DDL_EXTRACTION_MSG);
This way you don't have to deal with the line feed or separator. Please give it a try.
Thanks, Tom
Hi Pranav,
For the method isUnsupportedDDLExtraction(), how about if you change the equals to startsWith like this?
return object != null && object.getCreateScript().startsWith(object.getBaseObject().UNSUPPORTED_DDL_EXTRACTION_MSG);
This way you don't have to deal with the line feed or separator. Please give it a try.
Thanks, Tom
Hello Tom,
I have tried the change you have suggested in above comment and It is working. I have checked in the changes in Pune branch with SVN R#11140.
Hello Tom,
I have tried the change you have suggested in above comment and It is working. I have checked in the changes in Pune branch with SVN R#11140.
Hi Pranav, The change looks good. Please check it into the Pune trunk. Thanks, Tom
Hi Pranav, The change looks good. Please check it into the Pune trunk. Thanks, Tom
Hi guys,
This final string in the AFBaseDBObject is currently only used in one place. ExtractFunctions class for mssql server function extraction. When it was added the idea was that we could just associate the same message to any source object when we where unable to support the DDL extraction. I would recommend adding a boolean flag to the AFBaseDBOjbect _ddlExtractionSupport = true; If we are unable to extract the source and set the source to the final string UNSUPPORTED_DDL_EXTRACTION_MSG we could then set the flag there as well to _ddlExtractionSupport = false; We can then control this property and check it without possibility of error from a string compare. This would also allow for unsupported to be set for non source objects. Thoughts?
Hi guys,
This final string in the AFBaseDBObject is currently only used in one place. ExtractFunctions class for mssql server function extraction. When it was added the idea was that we could just associate the same message to any source object when we where unable to support the DDL extraction. I would recommend adding a boolean flag to the AFBaseDBOjbect _ddlExtractionSupport = true; If we are unable to extract the source and set the source to the final string UNSUPPORTED_DDL_EXTRACTION_MSG we could then set the flag there as well to _ddlExtractionSupport = false; We can then control this property and check it without possibility of error from a string compare. This would also allow for unsupported to be set for non source objects. Thoughts?
Hello Tom, Ivan,
I have followed the suggestion given in above comment and made changes in Pune branch to add and use _ddlExtractionSupported
flag with SVN r#11189.
Thanks,
Pranav
Hello Tom, Ivan,
I have followed the suggestion given in above comment and made changes in Pune branch to add and use _ddlExtractionSupported
flag with SVN r#11189.
Thanks,
Pranav
Hi Ivan, Thank you for the advice...
Hi Pranav, Your change looks good. Please check it into the Pune trunk.
Thanks, Tom
Hi Ivan, Thank you for the advice...
Hi Pranav, Your change looks good. Please check it into the Pune trunk.
Thanks, Tom
Hello Tom,
I have checked in the changes in Pune Trunk with SVN R#11232
Thanks,
Pranav
Hello Tom,
I have checked in the changes in Pune Trunk with SVN R#11232
Thanks,
Pranav
@pranav: can you attach a screenshot showing what the user would see?
@pranav: can you attach a screenshot showing what the user would see?
@ Sachin,
If the object extraction is not supported by ADS then user will see "Error" in "Diff count" column. see screenshot.
Note: This screenshot is taken with Pune Trunk current rev[11268]. But same thing is throwing exception with ADS QA Build 202.
@ Sachin,
If the object extraction is not supported by ADS then user will see "Error" in "Diff count" column. see screenshot.
Note: This screenshot is taken with Pune Trunk current rev[11268]. But same thing is throwing exception with ADS QA Build 202.
@tom: pls try to reproduce the exception that @pranav is mentioning.
In addition, it seems the sync column shouldn't have a checkbox in such a situation where Error is displayed in Diff Count. I thought we were displaying a warning icon? Or is that for some other scenario?
@tom: pls try to reproduce the exception that @pranav is mentioning.
In addition, it seems the sync column shouldn't have a checkbox in such a situation where Error is displayed in Diff Count. I thought we were displaying a warning icon? Or is that for some other scenario?
Hi Tom,
I performed some tests for new changes with and without dependency extraction and new functionality is working fine. Please see screenshot of new changes.
Hi Tom,
I performed some tests for new changes with and without dependency extraction and new functionality is working fine. Please see screenshot of new changes.
Verified in ADS-18.0.0-RC-7. Refer screenshot 'Updated_14353.png'
Verified in ADS-18.0.0-RC-7. Refer screenshot 'Updated_14353.png'
Issue #14353 |
Closed |
Fixed |
Resolved |
Completion |
No due date |
Fixed Build ADS 18.0.0-devi-205 |
No time estimate |
1 issue link |
relates to #14342
Issue #14342SQL Server 2014: NPE is thrown on selecting sys schema UDF in schema compare tool. |
@pranav: look at #14342 to detect this situation. If this situation is detected, can you put "Error" in the "Diff Count" column. We also put a different background color on the row to indicate error.