Progress:

Exploring updating parameters across dataSources.  Since the parameters are only modified in a small number of places, we can write methods to extend this update across datasources.  For example, say we limit "sharing" to parameters of the same name on different datasources (use case by customer).  We can iterate through datasources and modifyParameterField according to the new values.  Running through initial test cases to find obvious problems trouble spots for strategy.

Enforcing the "same name" means we can leverage all the existing name limits for parameters (error messaging, etc).

UI: If we include a checkbox that allows user to choose Shared or Make Parameter Global, etc we can track this when we modify the parameter.  We'll need to check isShared and make sure the active fieldmanager is not included in the update, since the existing modifyParameter handles that.

It might also be useful to render the name in italics or something similar to remind the user that a given parameter is shared across data sources.

Next step:  Can we handle all the changes via worksheetPane/fieldEvent?

Progress:

Tracking fieldEvents for nameChange, valueChange, format, dataType, etc to follow patterns for Sharing Parameter changes.

Value changes including undo/redo working in quick prototype, so can expand strategy to fieldEvents / other parameterData changes (after design discussion, etc).

Progress:  Testing discussed with Sachin re: parameter field names and data refresh.

1) Parameter cannot share name with existing field, paramterField or otherwise.  If User attempts to rename/create parameter with existing name, standard "field already exists" error message is given.

2) If field is renamed in datasource to existing ParameterField name, it will be appended with "1" on data refresh.  This is same behavior for any field renamed in datasource with duplicate name.  Column name can be shared, but field name is changed to prevent duplicates.

Options 1 and 2 are large in scope. We should go with a modified option 3 as follows:

1. Allow parameters to be linked to another parameter of the same name and type across different datasources of the user's chosing. The values of the linked parameters will be synchronized to the value of the current parameter that's being linked.
2. A linked parameter can be unlinked by the user.
3. Linking and unlinking are undoable/redoable. Synced parameters values are also restored to their original values when undoing the link action.
4. Once a parameter is linked, it can no longer be edited (except for the parameter value) or deleted. The user must unlink it first.
   • We can enhance this in a future release to allow editing of linked parameters. This is a larger effort as the editing must be validated across and propagated to other datasources. For example, renaming a linked parameter must not conflict with any existing fields or parameters in linked datasources.
5. Removing a datasource will automatically unlink all linked parameters in this datasource for each linked parameter that exists in only one of the remaining datasources.
6. A linked parameter is NOT automatically added to a new datasource that is added to the data pane.
7. Modifying the value of a linked parameter will propagate to all datasources containing the same linked parameter.
8. The linked state of the parameter must be persisted when the workbook is saved.

Please make the following changes:

1. Rename the "Link Parameter" option in the parameter right-click menu to "Link with Selected Datasources...". When I select this menu option, it should display a dialog box similar to link-parameter.jpg:
   • The style of the dialog box should be similar to share-filter.png. For example, the default active "Link" button should be blue highlighted as the "Share" button in share-filter.png.
   • List all datasources that contain the same parameter of the same type.
   • The datasource where the source parameter is from should be checked, grayed out, and disabled.
   • Datasource with the same parameter already linked should be checked.
   • Upon clicking the Link button, the parameter should be linked to only the selected datasources.
2. The "Link with Selected Datasources..." option should also be available to an already linked parameter. In this way the user can edit the links.
3. The "Unlink Parameter" option should unlink this datasource only. For example, let's say Parameter 1 is linked between Datasource1, Datasource2, and Datasource3. When I selected "Unlink Parameter" from Parameter1 in Datasource1, then Parameter 1 in Datasource1 is no longer linked to any other datasources. However, the Parameter1 in Datasource2 and Datasource3 should remain linked.

The following scenarios require fixing:

Scenario 1:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link Parameter"
3. Result: Currently it seems to link Parameter1 in all datasources. But note the above changes.
4. Click on the triangle menu in the Parameter1 control.
5. Result: "Link with Selected Datasources..." and "Unlink Parameter" menu options are NOT available, which is incorrect.
6. Expected: The availability of these 2 menu options should be similar to the right-click menu of the parameter field.
7. Goto Dashboard1
8. Click on the triangle menu in the Parameter1 control.
9. Result: "Link with Selected Datasources..." and "Unlink Parameter" menu options are NOT available, which is incorrect.
10. Expected: The availability of these 2 menu options should be similar to the right-click menu of the parameter field.

Scenario 2:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link Parameter"
3. Result: Currently it seems to link Parameter1 in all datasources. But note the above changes.
4. In the Parameter1 control, change the value to 5
5. Goto Worksheet 2
6. Result: The Parameter1 value is NOT changed 5, which is incorrect

Scenario 3:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link Parameter"
3. Result: Currently it seems to link Parameter1 in all datasources. But note the above changes.
4. Click the triangle menu in the Parameter1 control, and select "Edit...", then change the value to 5 in the Edit dialog
5. Goto Worksheet 2
6. Result: The Parameter1 value is changed 5, which is correct
7. Click the triangle menu in the Parameter1 control, and select "Edit...", then change the value to 6 in the Edit dialog
8. Goto Worksheet 1
9. Result: The Parameter1 value is still 5, which is incorrect
10. Expected: Since the parameter is linked, the same parameter's value should be 6
11. Goto Worksheet 2
12. Click Undo
13. Result: Parameter1 value in Worksheet 2 is restored to 5, which is correct
14. Goto Worksheet 1
15. Result: Parameter1 value in Worksheet 2 is changed to 6, which is incorrect

SVN #56215 addresses the "Please make the following changes" section in this comment. However the remaining 3 scenarios are still not fixed. Additionally, the following scenario is observed:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Note that Parameter1 in all 3 datasources are completely unlinked.
3. Right-click on Parameter1 and select "Link with Selected Datasources..."
4. Select all datasources and click Link
5. Click Undo
6. Result: Parameter1 in Datasource 1 is unlinked from all datasources. However Parameter1 in Datasource 2 and Datasource 3 are still linked to each other, which is incorrect.
7. Expected: Parameter1 in all 3 datasources should be completely unlinked.

revision #56224

Changes: LinkParameterListener and UnlinkParameterListener are now separate classes. ParameterControlPanel and ParameterDashboardItem menu's now have an option to link/unlink the parameters.

revision #56226

Changes: Support proper editing support of existing linked parameters. This is required so that the value from the editing of one value could be propagated as the value to the others

revision #56227

Changes: Missed these two files in the last commit. Are required in the last commit.

Scenario 1:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Total Due in Measures pane, and select Rename...
3. Change change to anything and click Rename
4. Result: Rename fails with the following exception. This is caused by a change in Revision #55235.

   java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
   	at java.util.ArrayList.rangeCheck(ArrayList.java:657)
   	at java.util.ArrayList.get(ArrayList.java:433)
   	at com.aquafold.bistudio.sheet.BISheetWorksheetPane.handleFieldChanges(BISheetWorksheetPane.java:568)
   	at com.aquafold.bistudio.sheet.BISheetsPane.handleFieldChanges(BISheetsPane.java:907)
   	at com.aquafold.bistudio.event.BIFieldListenerQueue.notify(BIFieldListenerQueue.java:29)
   	at com.aquafold.bistudio.BIStudio.notifyFieldListener(BIStudio.java:1832)
   	at com.aquafold.bistudio.BIStudio.notifyFieldChanges(BIStudio.java:1821)
   	at com.aquafold.bistudio.model.BIFieldManager.fireFieldEvent(BIFieldManager.java:1947)
   	at com.aquafold.bistudio.model.BIFieldManager.runBatch(BIFieldManager.java:4081)
   	at com.aquafold.bistudio.model.BIFieldManager.renameDataField(BIFieldManager.java:3783)
   	at com.aquafold.bistudio.model.BIFieldManager.renameDataSourceField(BIFieldManager.java:973)
   	at com.aquafold.bistudio.model.BIFieldManager.renameDataSourceField(BIFieldManager.java:939)
   	at com.aquafold.bistudio.rename.RenameFieldDialog.execute(RenameFieldDialog.java:271)
   	at com.aquafold.bistudio.rename.RenameFieldDialog.onRename(RenameFieldDialog.java:110)
   	at com.aquafold.bistudio.rename.RenameFieldDialog$3.actionPerformed(RenameFieldDialog.java:105)
   	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
   	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
   	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
   	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
   	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
   	at javax.swing.plaf.basic.BasicRootPaneUI$Actions.actionPerformed(BasicRootPaneUI.java:208)
   	at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1663)
   	at javax.swing.JComponent.processKeyBinding(JComponent.java:2882)
           ...
   

5. Expect: Since the last datasource where Parameter1 is linked with has been removed, Parameter1 should now be unlinked

Scenario 2:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link with Selected Datasources..."
3. Select Datasource 2 and click Link
4. Right click on Datasource 2 and select Close
5. Right-click on Parameter1
6. Result: "Unlink Parameter" is still available, indicating that it's still linked
7. Expect: Since the last datasource where Parameter1 is linked with has been removed, Parameter1 should now be unlinked

Scenario 3:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link with Selected Datasources..."
3. Select all datasources and click Link
4. Result: Workbook is NOT marked dirty, which is incorrect
5. Expected: Linking a parameter should mark workbook dirty
6. Click on a bar to cause workbook to be dirty
7. Perform File > Revert to Saved menu option
8. Right-click on Parameter1 and select "Link with Selected Datasources..."
9. Result: All datasource is preselected, which is incorrect
10. Expected: Revert to Saved should restore all states as if the workbook is newly opened

Scenario 4:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link with Selected Datasources..."
3. Select all datasources and click Link
4. In the Parameter1 control, change the value to 22
5. Result:
   • VA window is not updated to show the updated value in the chart and in the parameter control, which is incorrect. However if you goto Worksheet 2 and then come back to Worksheet 1, the values are updated.
   • The new parameter value is only propagated to the parameter control in other worksheets, but not propagted to the chart in other worksheets, which is incorrect.

Scenario 5:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link with Selected Datasources..."
3. Select all datasources and click Link
4. Click the triangle menu in the Parameter1 control, and select Edit...
5. In the Edit Parameter dialog, change the value to 22 and click Save
6. Result: The Save fails and the "Index: 0, Size: 0" message is display in the dialog, which is incorrect.

Scenario 6:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click in a blank area in the Parameters pane, and select "Create Parameter..."
3. Click Save
4. Result: Fails to save with "Index: 0, Size: 0" message, which is incorrect. However, clicking Save a second time will work.
5. Expected: Save should work the first time.

Revision #56241

1. Fix for failing of renaming of the measure parameters with an array index out of bounds exception.
2. Unlinking of the parameter on closing of the datasource to which it was associated
3. Revert to Saved should restore all states as if the workbook is newly opened. Also, linking/unlinking of parameter will mark sheet as dirty
4. Fixed the case where after linking a parameter in case edited from the ParameterControlInput of Sheet it fails.
5. Creating a parameter in the worksheet was failing for the first time but succeeded in the next time.

Scenario 4 mentioned above is partially fixed since only the dataSource to which the parameter is associated is refreshed. This results in updating only the worksheet or chart where this datasource is marked as the primary datasource.

Revision #56244

Corrected a failing check for linked parameter propagation, which leads to a hung ChartPanel wherein "Computing Visualization" is observed.

In SVN rev 56248, I've fixed the existing bug where updating a parameter value in dashboard is not reflected in the chart unless the parameter belongs to the last selected worksheet. However following scenario as noted before is still observed:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link with Selected Datasources..."
3. Select all datasources and click Link
4. In the Parameter1 control, change the value to 22
5. Result: The new parameter value is only propagated to the parameter control in other worksheets, but not propagted to the chart in other worksheets, which is incorrect. Further, even if I drag and drop a field in Rows deck slightly right of it to cause the cause chart to update in other worksheets, the old parameter value is still being rendered in the chart.

The root cause is that ParameterColumn.setValue(newValue) is being invoked only for the parameter field corresponding to the parameter control. The same method is not invoked for the linked parameters in other datasources. This method must be invoked for each linked datasource in order for the chart using the datasource to observe the new parameter value.

Also, the use of "isLinked" in BISheetworksheetPane is incorrect. It will cause more rebuilding of worksheets than necessary. For example, if I change the value of a linked parameter, it will cause all datasources to get rebuilt, even those that the parameter is not linked with. Instead it should rebuild/refresh only the linked datasources, for example using similar logic as in line 1830 of BISheetworksheetPane.

Revision #56252

Hi Nhi,

Thanks for fixing the known issue. Following are the new changes.

1. Excluded BISheetworksheetPane to use isLinked flag from event. This is to avoid multiple refreshing of sheets.
2. Propagating the linked values of a parameter by updating the fieldManager of corresponding datasource and not through notifying various events. Chart gets updated by this fix.
3. Linking/Unlinking and correspondingly Undo/Redo use this mechanism of modifying a parameter field through field manager.

Revision #56253

Accidentally reverted a change in last commit which was committed by Nhi to solve an existing issue.

The change of approach in SVN #56252 is incorrect. The notification infrastructure for handling datasource changes may be complicated, but it was necessary due to the nature of how VA works. In VA, data queries and model calculations can be time consuming, so they are handled in background threads to avoid locking up the GUI. This introduces contentions between foreground (GUI) and background threads, and thus a lot of safeguards had to be put in place to handle this delicate nature. Thus the handling of parameter changes (which is a type of datasource change) must be done via the existing notification infrastructure. And this is the reason why long delays are observed in the parameter operations after SVN #56252. Perhaps it may be possible to use direct handling of datasource changes rather than the notification machanism, but that will be a HUGE effort, not something that can fit in the timeframe of this project.

Please revert the code changes and use another approach to fix the scenario observed in this comment.

As I mentioned in the call.
Found an existing issue while editing and undo parameter value.

Scenario

1. open VA link-param.vizx
2. go to the dashboard
3. Change parameter1 value to 30 of worksheet 3.
4. click Undo. 
5. Parameter1 of worksheet 2 got changed while parameter1 of worksheet 3 remain unchanged
(Which is incorrect)

Thanks
Pankaj
 

Revision #56264

Changes: 

1. Updated the functionality of Linking/Unlinking of a Parameter by avoiding the modifyInternalParameterInternal method invocation and directly updating the ParameterColumn from the fieldManager of the corresponding field through the "Field Manager".
2. Completed various scenarios to cover linking/unlinking of linked parameters. Also, handled Undo/Redo cases corresponding to these.
3. Fixed an existing and unreported bug which occurs when you try to update a Parameter in the dashboard panel and perform an Undo/Redo operation, whose dataSource is not the current dataSource of the window. In this case, the corresponding parameter of the same name available in the currently selected datasource gets updated. This issue is reported by Pankaj in the above comment.
4. Reverted unrequired code which was used earlier to propagate the value changes via BIWorkSheetSheetPane.

Scenario 1:

1. Open link-params.vizx in VA, goto Dashboard 1
2. In the 2nd parameter control (which is for Worksheet 2), change the value from 3 to 30
3. Goto Worksheet 1
4. Result: Even though Datasource 1 is selected in the Data pane, the fields in Dimensions, Measures, and Parameters panes actually belong to Datasource 2. For example, if you select Datasource 2, then select Datasource 1, those fields will now reflect the actual fields from Datasource 1.
5. Expected: When I goto Worksheet 1, the fields in Dimensions, Measures, and Parameters panes should belong to Datasource 1.

Hi Nhi,

Actually, this problem is introduced after Revision #56248 where the dataSource is selected from the event rather than the default one. I reverted your changes locally and then was not able to reproduce it. Could you please have a look into it.

All the above scenarios other than the last scenario are working fine as expected.

As Hussain has already cleared that due to Revision #56248 last scenario is getting reproduced.

Nhi, Please confirm whether I should mark it verified?

In SVN #56274 I've fixed the last scenario here.

However the following scenarios are still broken:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link with Selected Datasources..."
3. Select all datasources and click Link
4. Click on the triangle menu in the Parameter1 control, select Edit...
5. In the Edit Parameter dialog, change the value to 20 and click Save
6. Result: The new parameter value is NOT propagated to Worksheet 2 and Worksheet 3, which is incorrect
7. Expected: Updating a linked parameter value should propagate to all linked datasources

Hi Nhi,

The above scenario is fixed. I also fixed some issues related to undo redo operations.

While testing above scenario, I observed one existing issue which is also fixed in below change set.

The issue was,

1. Open link-params.vizx in VA, goto Dashboard
2. Try to Edit Parameter1 for first sheet using Edit Parameter dialog
3. Result: The value is not updated in Parameter1 field
4. Expected: The value should be updated in Parameter1 field

Same problem is with Parameter1 for second sheet. When try to edit Parameter1 for third sheet using Edit parameter dialog then "A field named 'Parameter1' already exists" error occurs in the Edit Parameter dialog.

Root Cause:
In the ParameterFieldDialog class, at the line no. 374 (in the latest change), the fieldManager instance is extracted from _parentWindow.getSelectedDataSource()

Fix: 
I am getting fieldManager instance from _field.getDataSource()

Please have a look

Scenario 1:

1. Open link-params.vizx in VA, goto Worksheet 1
2. Right-click on Parameter1 and select "Link with Selected Datasources..."
3. Select Datasource 1 and Datasource 2 and click Link
4. Goto Worksheet 3
5. Right-click on Parameter1 and select "Link with Selected Datasources..."
6. Unselect Datasource 1 such that only Datasources 2 and 3 are selecgted, then click Link
7. Click Undo
8. Result: Undo fails to restore to the state right before step 5, which is incorrect
9. Expected: In this case, Parameter 1 should be linked between Datasources 1 and 2

Hi Nhi,

I fixed above scenario as well as some other undo scenarios. Please have a look.

Looks good.

@QA: Please retest all past scenarios.

Hi,

All the above scenarios are working fine as per the expectations on  ADS19.5.0-dev-65 build. Hence marking it as Verified.