#15101: Sybase ASE -> Extraction of parameters requires uint, ubigint & usmallint conversion to unsigned <type>

ivangron reported 2017-03-24T18:46:36Z · last modified 2017-05-31T18:03:56Z

Sybase ASE -> Extraction of parameters requires uint, ubigint & usmallint conversion to unsigned <type>

Dev	ivangron
QA	tariqrahiman

Priority	Major
Complexity	Unknown

Component	DB - Sybase ASE
Version	18.0

When extracting parameters for procedures we need to convert the u<int_type> to unsigned <int_type>.

4 attachments

Screen Shot 2017-03-24 at 3.16.36 pm.png

2017-03-24T22:15:07Z

119 KB
v19-alpha-16.png

2017-05-30T11:09:26Z

31 KB
v19-alpha-19.png

2017-05-31T06:20:20Z

52 KB
v18-0-13-4.png

2017-05-31T06:20:20Z

48 KB

All Comments (10) Change History

ivangron 2017-03-24T18:54:21Z

Example:

CREATE PROCEDURE UINT_HELLO_WORLD @MYARG unsigned int = 3 output AS BEGIN SELECT @MYARG END

sp_procxmode 'UINT_HELLO_WORLD', 'Unchained'

declare @RETURN_VALUE int

select @RETURN_VALUE = 0

declare @MYARG uint <<<---- should read unsigned int

select @MYARG = 0

EXECUTE @RETURN_VALUE = UINT_HELLO_WORLD @MYARG output

declare @RETURN_VALUE_label varchar(255)

select @RETURN_VALUE_label = '@RETURN_VALUE: ' + convert(varchar(235),@RETURN_VALUE)

print @RETURN_VALUE_label

declare @MYARG_label varchar(255)

select @MYARG_label = '@MYARG: ' + convert(varchar(235),@MYARG)

print @MYARG_label

ivangron 2017-03-24T18:56:57Z

Extraction fixed so that datatype uint, ubigint and usmallint will correctly store the type as its unsigned <int_type> name.

Committed revision: 53687

tariqrahiman 2017-03-24T22:14:00Z

Verified in ADS v18.0.5-12

tariqrahiman 2017-03-25T02:29:33Z

Verified in ADS v17.0.12-3

JennyNishimura 2017-03-30T00:11:25Z

Code review comments:

- We added AFTableColumnInfo.getDataTypeString method for this issue.
- We added UtilScript.getTranslatedDataType method for issue #14813.

Shouldn't we add the Sybase ASE logic to UtilScript.getTranslatedDataType rather than adding another data type method?

Shavi57 2017-05-30T11:13:01Z · (edited)

Product: Aqua Data Studio

Version: 19.0.0-alpha-16

Build #: 54515

Build Date: 2017-May-28 05:08:59 PM

Operating Environment: Linux (4.4.0-78-generic, amd64) / UTF-8 / en / IN / Oracle Corporation 1.8.0_102-b14

Memory: Max=704,643,072; Total=394,264,576; Free=271,391,248; CPUs=8

Database version: Sybase ASE 16

1. Execute given script in query analyzer

sp_addtype "udt_unsigned_int", "Unsigned int", "Null"

2. Expand User Defined Datatype node

3. Select created UDT and right click on it

4. Choose option "Script object to window" > CREATE

Actual result: The extracted physical datatype is incorrect. The extracted physical datatype is "uint" instead of "unsigned int". This causes failure of DDL causing error " Physical datatype does not exist."

Please see this screenshot.

Expected Result: The extracted physical datatype should be "unsigned int".

Observation:

This issue is reproducible in v17.0.12

ivangron 2017-05-30T22:31:23Z

Changes made so that extraction of datatype will correctly fix its type string. For US trunk I have also refactored the AFTableColumnInfo.getDataTypeString method into the UtilScript.getTranslatedDataType method.

Checked into US trunk with Committed revision: 54539

Checked into v18 source control with Committed revision: 54536

Checked into v17 source control with Committed revision: 54534

SachinPrakash 2017-05-31T03:26:13Z

@qa: pls test in v18 & v19

Shavi57 2017-05-31T06:23:02Z

I have verified below scenarios:

--- Procedure

CREATE PROCEDURE UINT_HELLO_WORLD @MYARG unsigned int = 3 output AS BEGIN SELECT @MYARG END

sp_procxmode 'UINT_HELLO_WORLD', 'Unchained'

--- UDT

sp_addtype "udt_unsigned_int", "Unsigned int", "Null"

In ADS 19-alpha-19 and v18.0.13-4, the above scenarios are scripted correctly. Please refer this screenshots for ADS 19-alpha-19 and v18.0.13-4.

The ADS build v17.0.14 is not available yet. So I will mark this issue Verified after testing these scenarios on v17.

tariqrahiman 2017-05-31T18:03:56Z

Verified in ADS v19.0.0-alpha-21 and 18.0.13-5

Search Tips

Aqua Data Studio / nhilam

Sybase ASE -> Extraction of parameters requires uint, ubigint & usmallint conversion to unsigned <type>

4 attachments

Issue #15101

Completion

Search Tips

Aqua Data Studio / nhilam

Title

Sybase ASE -> Extraction of parameters requires uint, ubigint & usmallint conversion to unsigned <type>

4 attachments

Issue #15101

Completion