The Row Header columns are resizable in Table mode, but fixed to certain predefined widths in Chart mode. In this issue, we want to allow the user to resize the Row Header column in Chart mode. The UI should the same as in Table mode, which is by dragging the edge on the right hand side of the Row Header column.

Once the user has manually resized a Row Header column, the following are true:

1. The user selected size of the Row Header column is persisted, and the automatic sizing of this column is ignored. This size is persisted both when the user duplicates this worksheet, as well as when the workbook is saved.
2. The manual sizing of the column is bound to the corresponding field in the Rows deck as follows:
   • Scenario:
     • Chart type = Bar
     • Columns = SUM(Sales)
     • Rows = Region, State
     • The user manually resized the column for State
   • Behavior:
     • When the user swaps the order of the Region and State fields in the Rows deck, the manual sizing of the Row Header column for State should be retained.
     • When the user removes the State fields in the Rows deck, the manual sizing of the Row Header column is also removed.
     • The Worksheet > Clear > Manual Sizing operation should remove all manual sizing of the Row Header columns.
     • The state of the Row Header column sizing should be restored when the user performs an undo/redo operation.

<visualanalytics:#15499> Need to be able to expand the width of a column

Committed revision 56043

Changes required to persist the state of the hierarchy are pending and I am working on it.

Revision #56049  

Following changes are completed.

1. Persisting the width of the row header columns after a file is saved or saved-as a different file.
2. Retaining the column width in case the Row Header(s) are swapped in the row-deck.

QA can pick this story for testing. Please pick build #19.

Scenario 1

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the edge of the Currency Code column header in the Row Header area so that the cursor turns into the vertical resize cursor. Then move the mouse cursor slightly to the left so that the sort icon is highlighted and the cursor remains the resize cursor.
3. Click-drag the mouse cursor to the right by about 2 cm.
4. Result:
   • Sorting is applied to the Currency Code field, which is incorrect.  Expected: mouse drag should not perform the sort action.
   • The row header width is not changed, which is incorrect.
   • The following error is displayed in the datastudio.log file, which is incorrect:
     java.lang.NullPointerException at com.aquafold.aquacore.open.chart.bi.BIChartHoverHandler.drawGuidingLinesColumnResize(BIChartHoverHandler.java:352) at com.aquafold.aquacore.open.chart.bi.BIChartHoverHandler.drawGuidingLines(BIChartHoverHandler.java:293) at com.aquafold.aquacore.open.chart.bi.BIChartHoverHandler.mouseDragged(BIChartHoverHandler.java:541) at com.aquafold.aquacore.open.chart.bi.BIChartPanel$BIChartMouseAdapter.mouseDragged(BIChartPanel.java:911) at java.awt.Component.processMouseMotionEvent(Component.java:6581) at javax.swing.JComponent.processMouseMotionEvent(JComponent.java:3342) at java.awt.Component.processEvent(Component.java:6302) at java.awt.Container.processEvent(Container.java:2238) at java.awt.Component.dispatchEventImpl(Component.java:4889) at java.awt.Container.dispatchEventImpl(Container.java:2296) at java.awt.Component.dispatchEvent(Component.java:4711) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4897) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4551) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4475) at java.awt.Container.dispatchEventImpl(Container.java:2282) at java.awt.Window.dispatchEventImpl(Window.java:2746) at java.awt.Component.dispatchEvent(Component.java:4711) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90) at java.awt.EventQueue$4.run(EventQueue.java:733) at java.awt.EventQueue$4.run(EventQueue.java:731) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.awt.EventQueue.dispatchEvent(EventQueue.java:730) at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866) at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:650) at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
     
     java.lang.ArrayIndexOutOfBoundsException: -1 at java.util.ArrayList.elementData(ArrayList.java:422) at java.util.ArrayList.get(ArrayList.java:435) at com.aquafold.aquacore.open.chart.bi.BIChartWorksheet.getColumnWidth(BIChartWorksheet.java:117) at com.aquafold.aquacore.open.chart.bi.BIChartPanel.setPreferredRowHeaderColumnWidthUndoable(BIChartPanel.java:1741) at com.aquafold.aquacore.open.chart.bi.BIChartHoverHandler.resizeCells(BIChartHoverHandler.java:272) at com.aquafold.aquacore.open.chart.bi.BIChartHoverHandler.handleLeftClickRelease(BIChartHoverHandler.java:264) at com.aquafold.aquacore.open.chart.bi.BIChartHeaderHoverHandler.handleLeftClickRelease(BIChartHeaderHoverHandler.java:312) at com.aquafold.aquacore.open.chart.bi.BIChartPanel$BIChartMouseAdapter.mouseReleased(BIChartPanel.java:712) at java.awt.Component.processMouseEvent(Component.java:6533) at javax.swing.JComponent.processMouseEvent(JComponent.java:3324) at java.awt.Component.processEvent(Component.java:6298) at java.awt.Container.processEvent(Container.java:2238) at java.awt.Component.dispatchEventImpl(Component.java:4889) at java.awt.Container.dispatchEventImpl(Container.java:2296) at java.awt.Component.dispatchEvent(Component.java:4711) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4897) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4534) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4475) at java.awt.Container.dispatchEventImpl(Container.java:2282) at java.awt.Window.dispatchEventImpl(Window.java:2746) at java.awt.Component.dispatchEvent(Component.java:4711) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90) at java.awt.EventQueue$4.run(EventQueue.java:733) at java.awt.EventQueue$4.run(EventQueue.java:731) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.awt.EventQueue.dispatchEvent(EventQueue.java:730) at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866) at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:650) at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Scenario 2

1. Open the attached expand-column.vizx workbook in VA.
2. Try various actions to resize the row header width.
3. Result: It does not consistently resize evertime, which is incorrect.
4. Once you get it to resize twice, click Undo twice.
5. Click Redo once -- nothing seems to happen, which is incorrect
6. Click Redo again -- nothing seems to happen, which is incorrect
7. Move mouse over to chart area -- row header width is resized. I should NOT have to move the mouse to the chart area to see the Redo restoring the row header width.

Please list all unit tests that you have run to verify this issue and test thoroughly, as this feature in its current state seems to be very buggy.

Hi Nhi,

Thanks a lot for trying this out and revealing the issues to me. I think the placement of the sort icon very close to the column edge was responsible for the mix up of two actions. I have shifted it away just like in 'Table' mode to avoid that issue. Also, I have to repaint the BIChartPanel in order that Undo/Redo works properly.

For now, I have used the analytics sheet provided by you as well as the index.vizx sheet.

[Nhi]

Hi Hussain,

It seems to work much better with the latest checkin. However, I now notice the following problems. Please start each scenario by reopening the workbook as there seems to be some problems with states.

Scenario 3:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse at the right edge of the "Currency Code" header cell.
3. Result: Resize cursor is displayed, which is correct.
4. Move mouse to the right a little beyond the right side boundary of the "Currency Code" header cell.
5. Result: The mouse cursor remains as resize cursor, which is incorrect.
6. Expected: When a resize action is not allowed at the current mouse position, the mouse cursor should be normal cursor, not resize cursor.

Scenario 4:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse at the right edge of the 1st "SUM(Height)" axis.
3. Result: Resize cursor is displayed, which is incorrect.
4. Expected: When a resize action is not allowed at the current mouse position, the mouse cursor should be normal cursor, not resize cursor.
5. Note that this problem occurs only for the 1st "SUM(Height)" axis.

Scenario 5:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse at the right edge of blank row header cell (the one above the "AUD" row header cell).
3. Result: Resize cursor is displayed, which is correct.
4. Move mouse slowly to right until you reach the right edge of the SUM(Height) axis. Make sure the axis still has the gray highlight.
5. Drag the right edge to the right about 2 inches and release the mouse button.
6. Move the mouse to the left, back to the center of the blank row header cell.
7. Result: The resize cursor remains, which is incorrect. At this point, if you click the mouse button, the row header width is resized to this point. There seems to be a state problem.

Scenario 6:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse at the right edge of blank row header cell (the one above the "AUD" row header cell).
3. Result: Resize cursor is displayed, which is incorrect.
4. Move mouse slowly to right until you reach the right edge of the SUM(Height) axis. Make sure the axis still has the gray highlight.
5. Drag the right edge to the right about 2 inches and release the mouse button.
6. Move the mouse to left and click on the blue bar in the chart area.
7. At this point, do NOT move the mouse into any tooltip or outside of the chart canvas. Focus must remain in the chart canvas.
8. Move the mouse to hover over the right edge of the "Currency Code" header cell.
9. Result: The mouse cursor is not turned into the resize cursor, which is incorrect. Note that this seems like a state issue where the hover handler is in a bad state.
10. At this point, if you move the mouse outside of the chart canvas (ie move to the Rows deck) and then back into the canvas, then the mouse cursor turns into the resize cursor and we end up in the same situation as Scenario 5 above.

Scenario 7:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse at the right edge of the "Currency Code" header cell and resize the cell.
3. Perform the Worksheet > Clear > Manual Sizing menu action.
4. Result: The row header width manual sizing is not cleared until you move the mouse back into the chart canvas.
5. Expected: The row header width should be updated without having to move the mouse back into the canvas.
6. Click Undo.
7. Result: The row header width is not restored to the state prior to the clear manual sizing, which is incorrect.

1. Rendering of guiding lines on canvas rather than on BIChartOverlayPane.
2. Handling of various scenarios where the RESIZE cursor should be turned back into a normal cursor.
3. Repainting the panel after clearing the preferred sizes. 

A few more scenarios:

Scenario 1:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the blank row header cell (the one above the "AUD" row header cell).
3. Result: The gray highlighting is smaller than the actual cell dimensions, which is incorrect. This problem is not observed in v19.0, and is likely caused by this issue.
4. Expected: The gray highlighting should cover the extent of the cell, just like hovering over the "AUD" row header cell.

Scenario 2:

1. Open the attached expand-column.vizx workbook in VA.
2. Move mouse into a blank part of the chart area without passing over any row header cells. For example, do NOT cause the resize cursor to be displayed.
3. Click on blank area in chart, drag the mouse and then release mouse button.
4. Now hover over the right edge of any row header cell.
5. Result: The resize cursor is not displayed and resize action does not work, which is incorrect.

Scenario 3:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover over the right edge of any row header cell.
3. Result: The resize cursor is displayed.
4. Move mouse into a blank part of the chart area.
5. Click on blank area in chart, drag the mouse and then release mouse button.
6. Now move mouse to the middle of any row header cell.
7. Result: The resize cursor is displayed and resize action at this location is available, which is incorrect.
8. Expected: The resize cursor should not be displayed and resize action should not be available in the middle of a cell.

Scenario 4:

1. Open the attached crash.vizx in VA
2. Close VA
3. Result: VA fails to close and the following exception is logged:
   9/12 15:52:22.371 StudioLogger.error null java.lang.NullPointerException at com.aquafold.aquacore.open.chart.bi.BIChartPanel.clearPreferredSizes(BIChartPanel.java:1853) at com.aquafold.bistudio.sheet.BIWorksheetPanel.clearManualSizing(BIWorksheetPanel.java:995) at com.aquafold.bistudio.sheet.BIWorksheetPanel.clearWorksheet(BIWorksheetPanel.java:982) at com.aquafold.bistudio.sheet.BISheetsPane.onWindowClose(BISheetsPane.java:1112) at com.aquafold.bistudio.BIStudio.closeWindow(BIStudio.java:1201) at com.common.ui.CBaseFrame$1.windowClosing(CBaseFrame.java:111) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349) at java.awt.Window.processWindowEvent(Window.java:2054) at javax.swing.JFrame.processWindowEvent(JFrame.java:305) at java.awt.Window.processEvent(Window.java:2013) at java.awt.Component.dispatchEventImpl(Component.java:4889) at java.awt.Container.dispatchEventImpl(Container.java:2296) at java.awt.Window.dispatchEventImpl(Window.java:2746) at java.awt.Component.dispatchEvent(Component.java:4711) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90) at java.awt.EventQueue$4.run(EventQueue.java:733) at java.awt.EventQueue$4.run(EventQueue.java:731) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.awt.EventQueue.dispatchEvent(EventQueue.java:730) at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866) at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:654) at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Hi Nhi and Juhi,

Thanks for testing out the various scenarios. I have fixed the scenarios reported by you in Revision #56099 

1. Several fixes related to the click and drag of mouse from outside of RowHeader/RowFieldHeader to inside.
2. Complete spanning of a cell selection over a cell area in RowHeader.
3. Fixing a crash occurring when a chart model is null.

Only the last change related to the clearing of 'Manual Resizing' option in an already existing file is left, which I will push in the next commit.

More scenarios:

Scenario 1:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the right edge of any row header cell.
3. Drag the resize guide line a little to right and all the way up to the Rows deck, and then release the mouse button.
4. Move the mouse to the middle of any row header cell.
5. Result:
   • The cursor turns into resize cursor and the resize guide lines are shown, which is incorrect.
   • At this point if you click the mouse button, the cell will be resized, which is also incorrect.
6. Expected:
   • No resize cursor should be shown in the middle of a cell, and guide lines should be shown only during mouse drag.
   • Seems like there's a state problem. The state of the resize handler should be reset.

Scenario 2:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the right edge of any row header cell and resize the cell a little.
3. Result: The cell is resized wider than where the mouse was released, which is incorrect.
4. Expected: The cell should be resized to where the mouse cursor is released.

Scenario 3:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the right edge of the "AUD" row header cell and drag to the right a little.
3. Result:
   • Cell is resized, which is correct.
   • However, the AUD row header cell is selected, which is incorrect.
4. Expected: Resizing a cell should not cause the cell to be selected (blue highlighted).

Scenario 4:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the right edge of any row header cell and drag to the right beyond the chart area.
3. Result: The resize guide line disappears beyond the chart area.
4. Expected: The resize guide line should not disappear beyond the chart area.

Scenario 5:

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the right edge of any row header cell and immediately drag to the right before the tooltip appears. (The reproducibility depends on the timing of this step).
3. Result: The resize guide line disappears, cell not resized, and we end up in the same state as scenario 1 above.
4. Expected: The resize guide line should not disappear and resize should work as expected. Note that this problem is probably caused by the interaction with the tooltip which seems to have appeared and disappeared during the mouse drag.

Thanks to Nhi and Nisha for the detailed testing.

I have pushed the changes in commit  #56111 

Changes:

1. Resize guiding lines to appear throughout the chart area
2. Drag and release the resize cursor in row deck area and resize cursor should not appear once we return back to rowFieldHeader or rowHeader
3. Fixing of the crash where the node key is null
4. Cell resize should not be wider than where it was left
5. After cell resize no selection should be made (immediate selection)
6. Disabling mouse tip to avoid the time-based issue

The changes should appear in build v19.5.0-dev-32

Regards

Hussain

HI Hussain
I found one issue 

Scenario :

1. Open the attached expand-column.vizx workbook in VA.
2. Hover the mouse over the right edge of any row header cell and drag to the right beyond the chart area.
3. Do not release mouse click.
4. Come back to Chart 
5. Result: Cursor of resizer is appearing
6. Expected: Normal Cursor.

Revision #56125 

Handling a null pointer exception when a child key is null

The scenario found by Pankaj here is not fixed. Similarly, if you drag the resize guideline into the Rows deck, do NOT release mouse button, drag back into the chart canvas, then release the mouse button. Now move the mouse into the middle of a row header cell and it will become the resize cursor, which is incorrect.

Also, scenario 5 here is only partially fixed. In step 2 if you drag diagonally to the right/down before the tooltip appears, then the problem is reproduced.

Scenario 1:

1. Open expand2.vizx in VA, goto Worksheet 1
2. Hover over the right edge of the SUM(Freight) axis
3. Result: resize cursor is shown and resizing of the axis is enabled
4. Goto Worksheet 2
5. Hover over the bottom edge of the SUM(Freight) axis
6. Result: resize cursor is NOT shown and resizing of the axis is NOT enabled
7. Expected: Resizing of vertical and horizontal axis should be consistent. Either allow none, or allow both.

Scenario 2:

1. Open expand2.vizx in VA, goto Worksheet 1
2. Hover over the right edge of the SUM(Freight) axis, and expand the width of the axis by 2 cm
3. Click Undo
4. Result: The axis width is NOT restored, but the width of the chart cells is narrowed, which is incorrect.
5. Expected: Undo should restore state prior to the last operation

Scenario 3:

1. Open expand2.vizx in VA, goto Worksheet 1
2. Hover over the right edge of the SUM(Freight) axis, and expand the width of the axis by 2 cm
3. Click the "Swap rows and columns" icon
4. Result: The axis scale is compacted to only a fraction of the entire axis width, which is incorrect.
5. Expected: The axis scale should occupy the entire width of the axis.

Solution: Either fix the above 3 scenarios, or remove the ability to resize the width of the vertical axis, which ever is easier. Note that resizing of the width of the vertical axis is NOT a requirement.

Hi Nhi,

Thanks for suggesting the solution for this. However, implementing both axes height/width was akin to each other, just a few parametric changes were required and hence I decided to implement the same. I have pushed the changes along with solutions for your input scenarios of "Fit Chart" options in #13331. Please take the update of Revision # 56154.

QA - Please pick up build # 39 to test the same

Scenario 1:

1. Open expand3.vizx in VA, goto Worksheet 1
2. Hover on right edge of SUM(Freight) axis and expand the width by 1 cm
3. Hover on right edge of "ColonialVoice" and expand the width by 1 cm
4. Click on "Fit Chart" dropdown and select "Fit Width" or "Entire View"
5. Result:
   • Chart is expanded accordingly, which is correct
   • But the manual sizing of Row Headers column width and SUM(Freight) axis width is removed, which is incorrect
6. Expected: "Fit Chart" options should NOT affect Vertical Axis width and Row Header column width. They should be independent of each other.

Scenario 2:

1. Open expand3.vizx in VA, goto Worksheet 2
2. Hover on bottom edge of SUM(Freight) axis and expand the height by 1 cm
3. Click on "Fit Chart" dropdown and select "Fit Height" or "Entire View"
4. Result:
   • Chart is expanded accordingly, which is correct
   • But the manual sizing of SUM(Freight) axis height is removed, which is incorrect
5. Expected: "Fit Chart" options should NOT affect Horizontal Axis height. They should be independent of each other.

Scenario 3

1. Open expand3.vizx in VA, goto Worksheet 2
2. Hover on bottom edge of SUM(Freight) axis and expand the height by 1 cm
3. Perform Worksheet > Clear > Manual Sizing
4. Result: Manual sizing of SUM(Freight) axis height is not removed, which is incorrect

Scenario 4:

1. Open expand3.vizx in VA, goto Worksheet 2
2. Hover on bottom edge of "Currency Code" or "ColonialVoice"
3. Result: Resize cursor is shown, which is incorrect
4. Expected: In this release, which do not support manual sizing of column header height

1. Vertical Axis width and Row Header column width should be independent of Chart-Fit options.
2. Horizontal Axis height should be independent of Chart-Fit options.
3. Clear -> Manual Resize should clear Horizontal Axis Height too.
4. Do not enable Row resize cursor for ColumnHeaderTop pane and RowFieldHeader pane.

QA, please verify the changes in build #41

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Note that "Standard" is selected in the "Fit Chart" dropdown
3. Hover on right edge of "ColonialVoice" or SUM(Freight) axis and expand the width by 1 cm
4. Result: "Standard" is no longer selected in the "Fit Chart" dropdown, which is incorrect
5. Expected: "Fit Chart" options should be independent of Vertical Axis width and Row Header column width manual sizing. Thus the previously selected "Fit Chart" option should remain selected.

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 2
2. Note that "Standard" is selected in the "Fit Chart" dropdown
3. Hover on bottom edge of SUM(Freight) axis and expand the height by 1 cm
4. Result: "Standard" is no longer selected in the "Fit Chart" dropdown, which is incorrect
5. Expected: "Fit Chart" options should be independent of Horizontal Axis height manual sizing. Thus the previously selected "Fit Chart" option should remain selected.

Scenario 3:

1. Open expand4.vizx in VA, goto Worksheet 2
2. Note that "Standard" is selected in the "Fit Chart" dropdown
3. Hover on right edge of "ColonialVoice" or SUM(Freight) axis and expand the width by 5 mm
4. Click the "Swap rows and columns" icon
5. Result: The axis title and tick mark labels overlap
6. Expected:  Swap rows and columns should not transfer the horizontal axis manual height to vertical axis manual width, and vice versa. Instead this operation should clear any horizontal axis manual height and vertical axis manual width. Make sure the Undo correctly restores any horizontal axis manual height and vertical axis manual width.

Scenario 4:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on bottom edge of "ColonialVoice" or SUM(Freight) axis and shrink the height by 1 cm
3. Click Undo
4. Expand the VA window vertically
5. Result: The chart does not get expanded automatically, which is incorrect.
6. Expected: Since we have undone the last manual cell sizing, the cell sizing should now be automatic (ie same as clear manual sizing), and thus should expand or shrink with the VA window size.

Scenario 5:

1. Open expand4.vizx in VA, goto Worksheet 3
2. Hover on right edge of the vertical SUM(Profit) axis and expand the width by 1 cm
3. Result: The scale of the horizontal SUM(Freight) axis get compacted, which is incorrect
4. Expected: The manual width of a vertical axis should not affect the scale of another horizontal axis

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Note that "Standard" is selected in the "Fit Chart" dropdown
3. Hover on right edge of "ColonialVoice" expand the width by 1 cm
4. Click Undo
5. Result: "Standard" is no longer selected in the "Fit Chart" dropdown, which is incorrect
6. Expected: "Fit Chart" options should be independent of Vertical Axis width and Row Header column width manual sizing. Thus the previously selected "Fit Chart" option should remain selected.

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Click on the "Fit Chart" dropdown and select "Fit Width" or "Entire View"
3. Hover on right edge of "ColonialVoice" or SUM(Freight) axis and expand the width by 1 cm
4. Note that the possible combinations of steps 2 and step 3 represent 4 different scenarios. So after you fix this, make sure to verify all 4 possible combinations.
5. Result:
   • The previously selected "Fit Chart" option is still selected, which is correct
   • However, the chart is not displayed based on the selected "Fit Chart" option. For example:
     • ​A horizontal scroll bar is displayed, which is incorrect
     • When I resize the VA window horizontally, the width of the chart is not updated, which is incorrect
6. Click Undo
7. Result: The previously selected "Fit Chart" option is not restored correctly. For example, when I resize the VA window horizontally, the width of the chart is not updated, which is incorrect

Scenario 3:

1. Open expand4.vizx in VA, goto Worksheet 2
2. Hover on bottom edge of SUM(Freight) axis and expand the height by 1 cm
3. Click on the "Fit Chart" dropdown and select "Fit Height" or "Entire View"
4. Hover on bottom edge of SUM(Freight) axis and shrink the height by 1 cm
5. Click Undo
6. Result: The entire height is shrunk, which is incorrect
7. Expected: The height of the SUM(Freight) axis should be restored and the chart height should still respect the "Fit Height" or "Entire View" option

Scenario 4:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on right edge of "ColonialVoice" or SUM(Freight) axis and expand the width by 1 cm
3. Click the "Swap rows and columns" icon
4. Result: The width of the chart is incorrect
5. Expected: The width of a horizontally oriented chart based on "Standard" chart fit option should span the entire width of the VA window. A horizontally oriented chart refers to a chart with the measure fields in the Columns deck.

Scenario 5:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on right edge of "ColonialVoice" or SUM(Freight) axis and expand the width by 1 cm
3. Click Undo
4. Click the "Swap rows and columns" icon
5. Result: The width of the chart is incorrect
6. Expected: The width of a horizontally oriented chart based on "Standard" chart fit option should span the entire width of the VA window.

Scenario 6:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on right edge any column header and expand the width by 1 cm
3. Click the "Swap rows and columns" icon
4. Result: The width of the chart is incorrect
5. Expected: The width of a horizontally oriented chart based on "Standard" chart fit option should span the entire width of the VA window.

Note that part of the fix for scenarios 4, 5, 6 should take the following approach: The "Swap nows and columns" action should implicitly perform the Worksheet > Clear > Manual Sizing first (which clears all manual sizing of header column width, axis size, and cell size), and then perform the actual swapping. The Undo should do the usual undo of swapping and restore all previous manual sizing that was being cleared.

Revision #56181

1. Restore the previously selected “ChartFit” option on clicking undo after manually resizing the chart. The effect for e.g. “Standard”, “Fit Height”, “Fit Width” or  “Entire View” should be restored too.
2. A previously selected option of  “ChartFit” should be honored in case only RowHeader Width, Axis Width (vertical) or Axis Width (horizontal) is resized.
3. Subsequent to increasing the width of vertical axis or RowHeader, the horizontal scroll bar should not appear, which affects the horizontal fitment of chart for “Fit Width” and “Entire View”. The vertical/horizontal fitment of chart should be honored. To be tested by vertically or horizontally resizing the VA window.
   1. Please note that in case only two Axes, we have to apply the horizontal scroll bar after vertical axis’s width resizing, in order to make sure that horizontal scrollbar is not contracted. Please refer to Scenario # 5 reported on 26^th September.
4. Subsequent to increasing the height of vertical axis, both the vertical/horizontal fitment of chart should be honored.  To be tested by vertically or horizontally resizing the VA window.
5. Swapping of Rows/Columns should result in clearing off of manual resizing akin to the Worksheet -> Clear -> Manual Resize. (for scenarios 4, 5 and 6 reported above)

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on right edge of "ColonialVoice" expand the width by 1 cm
3. Click Undo
4. Result: The width of "ColonialVoice" is 2 mm wider than what it started with.
5. Expected: Undo should restore the row header column to its width prior to the resize operation.

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Click on the "Fit Chart" dropdown and select "Fit Height" or "Entire View"
3. Hover on bottom edge of SUM(Freight) axis and shrink the height by 1 cm
4. Result:
   • The chart cell is shrunk, which is correct.
   • However the "Fit Chart" remains as is, which is incorrect.
5. Expected:
   • If "Fit Chart" was "Fit Height", then it should become blank since manual cell height has been applied.
   • If "Fit Chart" was "Entire View", then it should become "Fit Width" since manual cell height has been applied, but the cell width has not been manually sized.

Scenario 3:

1. Open expand4.vizx in VA, goto Worksheet 2
2. Click on the "Fit Chart" dropdown and select "Fit Width" or "Entire View"
3. Hover on right edge of SUM(Freight) axis and shrink the width by 1 cm
4. Result:
   • The chart cell is shrunk, which is correct.
   • However the "Fit Chart" remains as is, which is incorrect.
5. Expected:
   • If "Fit Chart" was "Fit Width", then it should become blank since manual cell width has been applied.
   • If "Fit Chart" was "Entire View", then it should become "Fit Height" since manual cell width has been applied, but the cell height has not been manually sized.

Revision #56194

Fixed scenarios 2 and 3 mentioned in the above comment.

I am looking into scenario 1 where I think the precision loss is happening due to interconversion between float and integer datatypes.

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on "ColonialVoice"
3. Result: The sort icon is displayed 10 pixels from the right edge of the header cell
4. Expected: The sort icon should be displayed close to (maybe 5 pixels from) the right edge of the header cell. Make sure Scenario 1 in this comment is not regressed.

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Move mouse to white area of the chart, about 1 cm beyond the right edge of the chart.
3. Click and drag the mouse to the left and about 1 cm into the chart, then release the mouse button.
4. Verify the no exceptions has been logged.
5. Click on any bar to cause the workbook to become dirty.
6. Perform the File > Revert to Saved menu option.
7. (Instead of the above 2 steps, you can simply rename the Total Due field in the Measures pane to Total Due1. We just need to cause the chart panel to get rebuilt for this scenario.)
8. Move mouse to white area of the chart, about 1 cm beyond the right edge of the chart.
9. Click and drag the mouse to the left and about 1 cm into the chart, then release the mouse button.
10. Result: A bunch of the following exception is logged:

    java.lang.NullPointerException
    	at com.aquafold.aquacore.open.chart.bi.BIChartPanel$BIChartMouseAdapter.mouseDragged(BIChartPanel.java:932)
    	at java.awt.Component.processMouseMotionEvent(Component.java:6581)
    	at javax.swing.JComponent.processMouseMotionEvent(JComponent.java:3342)
    	at java.awt.Component.processEvent(Component.java:6302)
    	at java.awt.Container.processEvent(Container.java:2238)
    	at java.awt.Component.dispatchEventImpl(Component.java:4889)
    	at java.awt.Container.dispatchEventImpl(Container.java:2296)
    	at java.awt.Component.dispatchEvent(Component.java:4711)
    	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4897)
    	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4551)
    	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4475)
    	at java.awt.Container.dispatchEventImpl(Container.java:2282)
    	at java.awt.Window.dispatchEventImpl(Window.java:2746)
    	at java.awt.Component.dispatchEvent(Component.java:4711)
    	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
    	at java.awt.EventQueue.access$500(EventQueue.java:97)
    	at java.awt.EventQueue$3.run(EventQueue.java:709)
    	at java.awt.EventQueue$3.run(EventQueue.java:703)
    	at java.security.AccessController.doPrivileged(Native Method)
    	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
    	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
    	at java.awt.EventQueue$4.run(EventQueue.java:733)
    	at java.awt.EventQueue$4.run(EventQueue.java:731)
    	at java.security.AccessController.doPrivileged(Native Method)
    	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
    	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
    	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866)
    	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:650)
    	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381)
    	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
    	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
    	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
    	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
    	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
    	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

11. Expected: No exception should occur.

Revision #56221

Changes:

Handling of the null pointer exception, depicted in scenario 2 in the above comment.

Changing the placement of the icon closer to the right edge of the cell.

Hi Nhi,

I checked the issue for the following scenario.

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on the right edge of "ColonialVoice" expand the width by 1 cm
3. Click Undo
4. Result: The width of "ColonialVoice" is 2 mm wider than what it started with.
5. Expected: Undo should restore the row header column to its width prior to the resize operation.

While resizing the size of the column, we fetch the width from the selected cell and use to restore to this width after performing an Undo operation, which in the case of the rowfield Header comes out to be '85'. 

Though rendered cell width is actually calculated using BIChartRenderer::getFitCellWidth, which turns out to be '80'. Now, in this case, during a resizing of cell width, I only have selected cell's width available to me.

The only proper solution to this problem could be properly setting the value of the rowFieldHeader's cell width during preparing the workSheet. Right now, it is set through BIChartRenderer::getRowHeadersWidth, which causes it to differ from the fitCellWidth value.

I guess, undertaking this work for a cosmetic change would again increase the scope of the work. Please let me know your opinion about it.

Revision #56222

In case a Clear -> Manual Sizing is invoked while "Table" mode is active, ChartManualSizingInfo would not be available since ChartModel is not ready yet. Hence, we need to supply the default null values to it for various Chart related fields like RowHeaderHierarchy's width, Preferred Cell Width, Preferred Row Height etc.

Code Review:

The approach for the storage and persistence of the row header column width is incorrect. This approach uses the BIChartConfigAPI._nodeHeightWidthAttributes and PivotHeaderNode.width to store the row header column width. Because of the incorrect approach, the following scenario fails:

1. Open expand5.vizx in VA, goto Worksheet 1
2. Expand the 1st row header column
3. Drag the SUM(Freight) field in Columns deck and drop it a little to the right to cause the chart to get updated
4. Result: Both row header columns get expanded, which is incorrect

The mechanism for the storage and persistence of the row header column width already exists in Table mode, and the same mechanism should also be re-used in Chart mode. Basically the storage is in BIModelField._properties._columnWidth. If _columnWidth is NULL, it means that the column width is not manually sized. If it's not NULL, then its value should be used as the width of the corresponding row header column. By re-using the same mechanism, you can also leverage the undo logic for saving the state of the manual sizing.

I have attached 15499-prototype.patch, which is a simple prototype (which is NOT a complete solution) of re-using this mechanism for Chart mode. After you apply the patch, the resize action in Chart mode will no longer work because the prototype uses the table mode storage mechanism for row header column width. However you can see its effect by resizing the row header column width in Table mode first, then change chart type to Bar chart. You'll see that the row header width is retained. We could change the logic to first clear all manual sizing when changing chart type.

Please reach out to me if you have any questions regarding this. Perhaps we can talk tomorrow morning at 8:00 am pacific time.

Hi Nhi,

I completely agree with your observation and hence I am changing the persistence mechanism. Now, I am using two new fields in BIProperties and BIFieldPropertiesData to store preferredChartNodeWidth and preferredChartNodeHeight. From now, BIChartConfigAPI._nodeHeightWidthAttributes would act merely as a transient field so that we can handle the cases of Manual resizing during "Clear Manual resize" and "Swap of Rows/Columns".

Though I didn't took your patch and worked with it, yet I completely grasped the problem. However, I differ in opinion to reuse the table stuff in chart mode because in case we do so, we have to rework a lot of things and next we have to also "Clear the Manual sizing" of the chart before switching to the table mode.

Right now, after resizing the rows/columns in "Table" mode once we switch to the "Charts" and switch back to "Table" mode the manual sizing persists. In case, we leverage the existing fields used by the "Table" we may have to clear the fields while switching to and fro from the "chart mode" and reinstating fields from "Table" mode would entail further work. Hence, I think storing them in separate fields is better. Please let me know your opinion over it.

With Revision #56231, the scenario mentioned by you is fixed. 

Thanks - Hussain

There is imprecision when resizing row header width and the undoing of it. Consider the following scenario:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Use a rule to measure the with of the row header ==> w1
3. Hover on the right edge of "ColonialVoice" expand the width by 1 cm
4. Result: The width of row header is 10 pixels wider than where the resize guideline was dropped, which is incorrect
5. Click Undo
6. Result: The width of the row header is 10 pixels wider than w1, which is incorrect

This is because the row column width calculation later will add BIChartRenderer.INDENT to the size to accommodate some margins for the row header cells. Thus you must account for this.

I've attached 15499-fix-wrong-size.patch which address this. Please take a look and apply the patch with you don't see any problems with it.

---------------------------------------------------

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on the right edge of "ColonialVoice" expand the width by 1 cm
3. Click Undo
4. Result:
   • The BIProperties.preferredChartNodeWidth is not restored to NULL, which is incorrect
   • Worksheet > Clear > Manual Sizing is still enabled, which is incorrect
5. Expected: The BIProperties.preferredChartNodeWidth was previously NULL prior to the resize operation. Thus the undo should restore it to NULL.

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Remove Card Type from Rows deck
3. Remove SUM(Freight) from Rows deck
4. Result: An error dialog is displayed with message "An unexpected error occurred while processing your request". Clicking Show Details will show the following exception:

   java.lang.NullPointerException
   	at com.aquafold.bistudio.model.BIChartConfigAPI.createNodeTree(BIChartConfigAPI.java:699)
   	at com.aquafold.bistudio.model.BIChartConfigAPI.buildRowTree(BIChartConfigAPI.java:585)
   	at com.aquafold.bistudio.model.BIChartConfigAPI.reconfigure(BIChartConfigAPI.java:534)
   	at com.aquafold.bistudio.model.BIModel.calculateModelImpl(BIModel.java:1223)
   	at com.aquafold.bistudio.model.BIModel.access$200(BIModel.java:166)
   	at com.aquafold.bistudio.model.BIModel$2.process(BIModel.java:863)
   	at com.aquafold.bistudio.component.BISimpleProgressDialog.run(BISimpleProgressDialog.java:96)
   
   

#Revision 56238

Changes: 

1. Applied Nhi's changes for handling imprecision when resizing a row header width.
2. Clearing of BIProperties.preferredChartNodeWidth on undo operation of RowHeader width resize. Also the corresponding entry in nodeHeightWidthAttributes map is erased.
3. Handling of null pointer exception in case the row/column deck is cleared. This is because model Field will be null and hence need to be validated.
4. Undo should restore the row header column to its width prior to the resize operation. This is precisely to handle the case which we were not able to handle earlier.

Revision #56240

Fixing a bug where in manual clearing of sizes (do, undo, redo) were not reflecting properly for the RowHeaderTable in charts.

The following scenario is still observed:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on bottom edge of "ColonialVoice" or SUM(Freight) axis and shrink the height by 1 cm
3. Note that the Chart Fit option is now blank, which is correct
4. Click on the Swap Rows and Columns icon
5. Click Undo
6. Result: "Standard" is selected in the Chart Fit dropdown, which is incorrect
7. Expected: Since manual cell sizing is still in effect, the Chart Fit option should be blank

The Chart Fit dropdown itself is the root cause of the scenario in the previous comment. The problem can be reproduced in a much more basic scenario as follows:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on bottom edge of "ColonialVoice" or SUM(Freight) axis and shrink the height by 1 cm
3. Note that the Chart Fit option is now blank, which is correct
4. Drag and drop the Currency Code field in Columns deck slightly to the right to cause the chart to update
5. Result: "Standard" is selected in the Chart Fit dropdown, which is incorrect
6. Expected: Since manual cell sizing is still in effect, the Chart Fit option should be blank

Basically any operation that cause the chart to get updated will change the Chart Fit option back to Standard. This defect is a violation of requirement #7 in the Add manual cell sizing support issue #13331. Thus this defect must be fixed. You may change the implementation of this dropdown component if necessary.

Hi Nhi,

I am reverting the changes mentioned in the above with revision # 56258

Unfortunately, the above approach brings in more issues than solved. The problem with the ChartFitUI component is that it is invoked from BIToolBar::handleWorksheetTabChanges which makes it difficult to be explicitly controlled from any of our operations. To be precise the value set from the getSelectedValue() of this component is is directly derived from the four combinations arising out of the configAPI::isFitWidth and configAPI::isFitHeight.

Owing to this nature of setting the value in the combo box, it is never directly set by any of the operations -> Transpose of the rows & columns, Change of the chartFitment through combo box (again handled through handler to read the selected value). It is always done implicitly. It is only in Chart Resize that in order to meet the condition of setting the value of manual resize that we need to set the selected value to NULL.

Now after an undo/redo operation in case I am trying to set the value it succeeds first. But the value is reset later as event handling in the BIToolBar::handleWorkSheetTabChanges causes it is again to reset to the value on the basis of these two flags configAPI::isFitWidth and configAPI::isFitHeight.

If possible let me know in case we can discuss this today your morning.

[Nhi] Let's follow the Table mode approach.

1. In case "Entire View" is selected in the chart and ColumnWidth Resize is done it is set to "Fit Height"
2. In case "Entire View" is selected in the chart and RowResize is done it is set to "Fit Width"
3. In case "Fit Width" is selected in the chart and Column Width Resize is done it is set to "Standard"
4. In case "Fit Height" is selected in the chart and Row Resize is done it is set to "Standard"
5. Horizontal axis height resize operation doesn't affect the "ChartFitUI" option.
6. Changing the width of the RowHeader Columns doesn't affect the "ChartFitUI" option.

All Undo operations of Manual Clear Resizing, Swap of Rows/Columns and Manual changing of ChartFit UI option which affect the fitment should revert the state of the chart to the previous manually resized state.

In this way, we are able to achieve similarity alike Table mode.

QA. Please test the scenarios.

Revision # 56260

On selection of Fit-Width/Fit-Height options from ChartUI combo-box the corresponding scroll bars should not appear.

Thanks to Priyanka for figuring out the corner scenario.

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Select "Entire View" in Fit Chart dropdown
3. Hover on right edge of "SUM(Freight) axis and expand the width by 1 cm
4. Result: "Fit Height" is selected in the Chart Fit dropdown, which is incorrect
5. Expected: Resizing of the width of a vertical axis is NOT the same as regular "manual cell sizing", and thus should NOT have any effect on Fit Chart options.

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 2
2. Hover on bottom edge of "SUM(Freight) axis and expand the height by 2 cm
3. Select "Entire View" in Fit Chart dropdown
4. Hover on bottom edge of "SUM(Freight) axis and shrink the height by 1 cm
5. Result: "Fit Width" is selected in the Chart Fit dropdown, which is incorrect
6. Expected: Resizing of the height of a horizontal axis is NOT the same as regular "manual cell sizing", and thus should NOT have any effect on Fit Chart options.

1. Resizing of the width of a vertical axis should NOT have any effect on Fit Chart options.
2. Resizing of the height of a horizontal axis should NOT have any effect on Fit Chart options.

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on bottom edge of ColonialVoice or "SUM(Freight) axis and shrink the height by 1 cm
3. Select "Fit Width" in Fit Chart dropdown
4. Select "Standard" in Fit Chart dropdown
5. Result: Manual size height is lost, which is incorrect
6. Expected: Since we decided to go with the Table mode approach, Chart mode should be consistent with Table mode such that changing to Standard option should not remove manual cell sizing.

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on right edge of "AUD" and expand the width by 1 cm
3. Select "Fit Height" in Fit Chart dropdown
4. Select "Standard" in Fit Chart dropdown
5. Result: Manual size width is lost, which is incorrect
6. Expected: Since we decided to go with the Table mode approach, Chart mode should be consistent with Table mode such that changing to Standard option should not remove manual cell sizing.

Scenario 3:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on right edge of "ColonialVoice" and shrink the width so that the final width is 1 cm
3. Result: Final row header width is 1.8cm, which is incorrect
4. Expected: Table mode allows shrinking the row header width below the text length, thus the Chart mode should be consistent with Table mode. Is there a technical difficulty in doing so in Chart mode?

Code Review:

1. Change "Change column width on a chart" ==> "Change column width on chart"
2. Change "Change row height on a chart" ==> "Change row height on chart"
3. Change "Change column width on row header on a chart" == > "Change column width on row header"

Revision #56268

Changes:

1. Chart mode should be consistent with Table mode such that changing to Standard option should not remove manual cell sizing 
2. Chart mode should be consistent with Table mode such that changing to Standard option should not remove manual cell sizing Update Undo/Redo texts for Chart's row header resize
3. Update Undo/Redo texts for Chart's row header resize

Scenario 3 is going to take a significantly lot of time because we have to update the existing mechanism for drawTextInCell. Here the computation has to take many factors into account.

Before writing the text in the cell the textWidth is computed via the bounds of a Rectangle2D through textRenderer.getBounds(text). This is finally used to compute the minimum cell width which is required to draw the text in the cell. This is significantly different from Table Mode because there we don't have such level of sophistication. I guess it would be better than we do not undertake this change for now.

Hi,

All the above scenarios are working fine as per the expectations on  ADS19.5.0-dev-61 build. Hence marking it as Verified.

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on bottom edge of ColonialVoice or "SUM(Freight) axis and shrink the height by 1 cm
3. Select "Fit Width" in Fit Chart dropdown
4. Click Undo
5. Click Redo
6. Result: Manual size height is lost, which is incorrect

Revision #56275

Changes: Applying custom preferences after ChartFit Undo/Redo operation is no longer required since we are in coherence with table mode.

Hi Nhi,

I fixed both scenarios mentioned above. Please have a look.

The FitHeight and FitWidth is working as expected and also Entire View is working fine along with undo redo operations.

Scenario 1:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on bottom edge of ColonialVoice or "SUM(Freight) axis and shrink the height by 1 cm
3. Select "Fit Width" in Fit Chart dropdown
4. Perform Worksheet > Clear > Manual Sizing menu option
5. Result: "Fit Chart" option has been changed to Standard, which is incorrect. Same problem is observed for Table mode.
6. Expected: In both Table and Chart modes, the Worksheet > Clear > Manual Sizing should not change the Fit Chart option
7. Click Undo
8. Result: Fit Chart option is still not restored to "Fit Width", which is incorrect

Scenario 2:

1. Open expand4.vizx in VA, goto Worksheet 1
2. Hover on right edge of "AUD" header cell and expand the width by 1 cm
3. Select "Fit Height" in Fit Chart dropdown
4. Perform Worksheet > Clear > Manual Sizing menu option
5. Result: "Fit Chart" option has been changed to Standard, which is incorrect. Same problem is observed for Table mode.
6. Expected: In both Table and Chart modes, the Worksheet > Clear > Manual Sizing should not change the Fit Chart option
7. Click Undo
8. Result: Fit Chart option is still not restored to "Fit Height", which is incorrect

Looks good.

@QA: Please retest all past scenarios.

Hi,

All the above scenarios are working fine as per the expectations on  ADS19.5.0-dev-65 build. Hence marking it as Verified.

Reopen for the following breakage:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Click the Swap Rows and Columns icon
3. Result: The rows and columns are NOT swapped, and the java.lang.NullPointerException is logged:

This breakage is caused by BIChartPanel::getManualSizingInfo(). The breakage scenario is constructed by first setting Chart Type to Table on an empty worksheet before adding any fields to Rows and Columns decks.

Fixed null pointer exception mentioned in above comment. These changes are part of below mentioned revision no.: