please refer above screenshots.

Hi Pankaj / Komal,

The approach in your code changes is incorrect. A measure field should always be added to the pivot table as AREA_DATA regardless of whether it is continuous or discrete. The reason is that measure fields must be aggregated. Thus the difference between continuous and discrete measure fields is how we interpret the resulting pivot table data.

The pivot table results contain 3 components, which provides the data to render the table or chart as follows:

              | Column Headers
--------------+----------------------
Row Headers   |
              | Data Area
              |
              |

1. Column Headers -- BIModel.getColumnHeaderTableModel()
   • In Chart mode, it is BIModel.getChartsColumnHeaderTableModel
2. Row Headers -- BIModel.getRowHeaderTableModel()
3. Data Area -- BIModel.getDataTabelModel()
   • In Chart mode, it is BIModel.getChartDataTableModel() -- This is quite complicated as the returned table model depends on the actual chart configuration.

Normally the result of the measure fields are placed in the DataTableModel because they were always Continuous. For a Discrete measure field, we need to place its results in the RowHeaderTableModel or ColumnHeaderTableModel depending on whether it is in the Rows or Columns deck.

Thus you need to update BIDataTableModel, BIRowHeaderTableModel, and BIColumnHeaderTableModel classes to properly interpret the Discrete Measure Field. For Table mode, the ExtraRowHeaderTableModel class is used for the column header table model. For Chart mode, the data table model is represented by the BIChartsDataTableModel class hierarchy, which has complicated business logic; so you'll need to debug this in detail in order to properly understand how it works. You should get the Table mode working first before attempting the Chart mode.

I've added some commented out debug code in BIModel to print the content of the pivot table results. You can uncomment the code to enable this debugging. Search for BIDebugUtil.

The following scenarios are NOT added scope. They are test scenarios to help validate the implementation.

Scenario 1:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Expected: The resulting table should look like the screenshot in worksheet1.png

Scenario 2:

1. Open discrete-measure.vizx in VA, goto Worksheet 2
2. Change the Index field in Rows deck to Discrete mode
3. Expected: The resulting table should look like the screenshot in worksheet2.png

Scenario 3:

1. Open discrete-measure.vizx in VA, goto Worksheet 3
2. Change the Index field in Columns deck to Discrete mode
3. Expected: The resulting table should look like the screenshot in worksheet3.png

Scenario 4:

1. Open discrete-measure.vizx in VA, goto Worksheet 4
2. Change the Index field in Rows deck to Discrete mode
3. Rearrange the fields in the Rows deck so that the Index field is in the left-most position
4. Expected: The resulting table should look like the screenshot in worksheet4.png

Scenario 5:

1. Open discrete-measure.vizx in VA, goto Worksheet 5
2. Change the Index field in Rows deck to Discrete mode
3. Expected: The resulting table should look like the screenshot in worksheet5.png

Scenario 6:

1. Open discrete-measure.vizx in VA, goto Worksheet 6
2. Change the Index field in Columns deck to Discrete mode
3. Expected: The resulting table should look like the screenshot in worksheet6.png

Scenario 7:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Columns deck to Discrete mode
3. Move the Index field from the Columns deck to the right-most position in the Rows deck
4. Expected: The resulting table should look like the screenshot in worksheet7.png

The following are test scenarios to help validate the implementation for charts mode.

Scenario 1:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Expected: The resulting chart should look like the screenshot in charts1.png

Scenario 2:

1. Open discrete-measure.vizx in VA, goto Worksheet 2
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Expected: The resulting chart should look like the screenshot in charts2.png

Scenario 3:

1. Open discrete-measure.vizx in VA, goto Worksheet 3
2. Change the Index field in Columns deck to Discrete mode
3. Change chart type to Bar
4. Expected: The resulting chart should look like the screenshot in charts3.png

Scenario 4:

1. Open discrete-measure.vizx in VA, goto Worksheet 4
2. Change the Index field in Rows deck to Discrete mode
3. Rearrange the fields in the Rows deck so that the Index field is in the left-most position
4. Change chart type to Bar
5. Expected: The resulting chart should look like the screenshot in charts4.png

Scenario 5:

1. Open discrete-measure.vizx in VA, goto Worksheet 5
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Expected: The resulting chart should look like the screenshot in charts5.png

Scenario 6:

1. Open discrete-measure.vizx in VA, goto Worksheet 6
2. Change the Index field in Columns deck to Discrete mode
3. Change chart type to Bar
4. Expected: The resulting chart should look like the screenshot in charts6.png

Scenario 7:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Columns deck to Discrete mode
3. Move the Index field from the Columns deck to the right-most position in the Rows deck
4. Change chart type to Bar
5. Expected: The resulting chart should look like the screenshot in charts7.png

Functional Review of patch:

1. Scenario 1: The measure name column that's part of the Row headers should be removed.
2. Scenario 2: The measure name column that's part of the Row headers should be removed.
3. Scenario 3: The measure name row that's part of the Column headers should be removed.
4. Scenario 4: The Index column should be at the left-most position in the Rows headers.
5. Scenario 5: The "2005" and "2006" columns are missing in Worksheet 5. This is broken even before converting the Index to Discrete.
6. Scenario 6: Looks good.
7. Scenario 7: I don't understand your comment of "it seems scenario #7 is the existing behavior of the tool". Since the measure fields are in Columns deck, the measure names should be part of the Column Headers, not Row Headers. This can be fixed by fixing BIModelFieldAPI.isDataInRows() so that it returns false for this scenario. Even though the Index field is in Rows, it should not count as Data field for this purpose because it is Discrete.

New test scenario:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Move the Index field from Rows deck to Color dec
3. Change the Index field in Color deck to Discrete mode
4. Result: The "2006" column is missing in the pivot table, which is incorrect
5. Expected: The content of the pivot table should not be changed when a measure field in Color deck (or any decks in Chart Properties) is converted to Discrete. When a Discrete Measure Field exists in any decks in Chart Properties, do NOT apply the mapping logic that moves the discrete measure values to the row/column header table model.

More test scenarios for charts

Scenario 1:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Columns deck to Discrete mode
3. Move the Index field from the Columns deck to the right-most position in the Rows deck
4. Change chart type to Bar
5. Click on Axes in the Chart Properties panel
   • Select "Merged Axies, Shared Scale" for Axes Type
   • Select "Stacked" for Display Style
6. Expected: The resulting chart should look like the screenshot in stacked.png

Scenario 2:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Columns deck to Discrete mode
3. Move the Index field from the Columns deck to the right-most position in the Rows deck
4. Change chart type to Bar
5. Click on Axes in the Chart Properties panel
   • Select "Merged Axies, Shared Scale" for Axes Type
   • Select "Clustered" for Display Style
6. Expected: The resulting chart should look like the screenshot in clustered.png

Functional Review for Monday's patch:

• Scenario 7 is broken:
  • The measure names are missing from the Column headers, which is incorrect.
  • The values for Index in the Row headers have incorrect values
• A slight variation of Scenario 5 is broken:
  • Perform all steps in Scenario 5
  • Move the Index field from Rows deck to right-most position of Columns deck
  • Result:
    • The "Index along Currency Code..." appears in Row headers with the measure names, which is incorrect
    • The values for Index in the Column headers is incorrect
• The "New test scenario" is still broken.

Hi Nhi,

The implementation of all scenarios mentioned by Nhi except following couple of items:

The following sorting scenarios are broken due to this issue implementation:

Scenario A1:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Hover on the "1" Row header cell
4. Result: No sort icon is displayed in the row header cell
5. Expected: Since this scenario is valid for sorting by row, a sort icon should be displayed to allow the user to sort by row
6. Note that for sorting purpose, the Discrete measure field should be treated like a dimension field. When the user clicks on the sort icon, make sure the sorting is based on the SUM(Freight) values, not the values for the Index field.

Scenario A2:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Hover on the "2004" Column header cell
4. Result: No sort icon is displayed in the Column header cell
5. Expected: Since this scenario is valid for sorting by column, a sort icon should be displayed to allow the user to sort by column

Scenario A3:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Move Index in Rows deck to the left-most position
4. Hover on the "AUD" Row header cell
5. Result: No sort icon is displayed in the row header cell
6. Expected: Since this scenario is valid for sorting by row, a sort icon should be displayed to allow the user to sort by row

Scenario A4:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Move Index in Rows deck to the Columns deck
4. Hover on the "AUD" Row header cell
5. Result: No sort icon is displayed in the row header cell
6. Expected: Since this scenario is valid for sorting by row, a sort icon should be displayed to allow the user to sort by row

Scenario A5:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Move Index in Rows deck to the Columns deck
4. Hover on the 1st "1" Column header cell
5. Result: No sort icon is displayed in the column header cell
6. Expected: Since this scenario is valid for sorting by column, a sort icon should be displayed to allow the user to sort by column

Scenario A6:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Move Index in Rows deck to the Columns deck
4. Hover on the 2nd "1" Column header cell, and click on the sort icon
5. Result: The second column is not sorted correctly, which is incorrect. The results appears to be sorted by the 1st column.
6. Expected: When I click the sort icon for the 2nd column, the chart should be sorted by the second column.

Scenario A7:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Move Index in Rows deck to the Columns deck
4. Right click on the Index field in Columns deck and select Summarize Values From > Table (Across)
5. Hover on the "1" Column header cell, and click the sort icon
6. Result: The chart does not appear to be sorted correctly
7. Expected: When I click the sort icon for the 1st column, the chart should be sorted by the 1st column.

From Kunal:

Hi Nhi, Hi Thomas,

The latest changes (dev-68) are committed to SVN repository. Today’s commit include #15442 Charts implementation and scenario #7 (partial) implementation.

Pending items :

1. Disable dual axis for discrete fields for charts.
2. Sorting issues reported by Nhi on table/charts.
3. #15376.
4. Scenario #7 : The labels from column headers are not showing up for few discrete fields.

Could you please trigger a new build, so that the QA can test the things which are implemented so far.

Please let me know if you have any question/concern.

Thanks

Kunal

The 2 scenarios here are not working. The measure names color legend contain 3 entries, and each bar contains 3 segments, which is incorrect. Since one measure is converted to Discrete, there should only be 2 entries in the color legend, and 2 segments per bar.

The following scenarios are broken:

Scenario B1:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Click the Swap Rows and Columns icon
5. Result: The Index field in Columns deck becomes invalid (orange), which is incorrect
6. Expected: All fields should remain valid

Scenario B2:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Hover over the 1st cell (ie the cell with 42,585 value)
4. Result: The tooltip shows wrong value for Index, and there's no label for SUM(Freight), which is incorrect.
5. Expected: The tooltip should contain the following:
   • Currency Code:
   • YEAR(ShipDate): 2004
   • Index: 1
   • SUM(Freight): 42,583

Scenario B3:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Hover over the 1st cell in the "2005" column (ie the cell with 96,642 value)
4. Result: Index is missing in the tooltip, which is incorrect.
5. Expected: The tooltip should contain the following:
   • Currency Code:
   • YEAR(ShipDate): 2005
   • Index: 1
   • SUM(Freight): 96,642

Scenario B4:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change Chart Type to Bar
4. Hover over the 1st bar in the "2005" column (ie the cell with 96,642 value)
5. Result: Index is missing in the tooltip, which is incorrect.
6. Expected: The tooltip should contain the following:
   • Currency Code:
   • YEAR(ShipDate): 2005
   • Index: 1
   • SUM(Freight): 96,642

Scenario B5:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Add Profit field to Color deck
4. Result: There are 2 "2005" columns and the values in these 2 columns are incorrect.

Scenario B6:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change Chart Type to Bar
4. Add Profit field to Color deck
5. Result: The bars in the "2005" and "2006" columns become shortened, which is incorrect
6. Expected: Adding a measure field to Color deck should not change the size of the bars in the chart
7. Hover over the the 1st bar in the "2005" column
8. Result: The value for "SUM(Freight)" in the tooltip is "1.0", which is incorrect. This explain why the bar is shortened.

Scenario B7:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change Chart Type to Bar
4. Add Card Type field to Color deck
5. Result:
   • The Card Type color legend has only 1 entry, which is incorrect
   • The bars become black, which is incorrect
   • The size of the bars have changed, which is incorrect
6. Expected: The bar chart should look like the attached bar-chart.png

Scenario B8:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Remove the Index field in Rows deck
3. Change Chart Type to Bar
4. Add Card Type field to Color deck
5. Result:
   • The Card Type color legend is empty, which is incorrect
   • The bars become black, which is incorrect
6. Expected: The bar chart should look like the attached basic-bar.png. Note that this scenario does not contain Discrete measure field. It seems some code changes in this issue has broken the basic bar chart.

Scenario B9:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Remove the Index field in Rows deck
3. Change Chart Type to Shape
4. Add Card Type field to Shape deck
5. Result:
   • The Card Type shape legend is empty, which is incorrect
   • The chart failed to visualize (showing the gray "Computing Visualization screen), which is incorrect
6. Expected: The shape chart should look like the attached basic-shape.png. Note that this scenario does not contain Discrete measure field. It seems some code changes in this issue has broken the basic shape chart.

Scenario B10:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change Chart Type to Bar
4. Move SUM(Freight) from Columns deck to Rows deck
5. Result: Bar chart is displayed incorrectly
6. Expected: The bar chart should look like the attached bar-chart2.png.

From Kunal:

Hi Nhi, Hi Thomas,

The latest code (dev-69) is checked in. Below items are fixed ,however the QA could not test that. So could you please trigger a new build and share with us?

•     Sorting for tables.
•     Dual Axes for charts.
•     Measure names not to be included for discrete measures in the measure names color legend on color deck.
•     Condition to make the field valid in the columns deck after swapping them on charts.

Pending items:

•     Sorting for charts.
•     Tooltip issue for tables and charts.
•     Scenario #7 for tables.
•     Partial implementation of #15376.

We are targeting  the RC for 15th Nov, unless we fall into any issues from QA and unit testing against any scenario.

Please let me know if you have any question/concern.

Thanks
Kunal
 

Functional Review:

Most of the scenarios here are not fixed.

More broken scenarios:

Scenario C1:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Right-click on Worksheet 1 and select Duplicate Worksheet
4. Result: The Index field in the duplicate worksheet (Worksheet 9) becomes invalid (orange), which is incorrect
5. Expected: All fields should be valid
6. Click the Swap Rows and Columns icon in duplicate worksheet
7. Result: Chart fails to render, with "Computing Visualization" gray screen.
8. Expected: Chart should get rendered

Scenario C2:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Click the Swap Rows and Columns icon
5. Result:
   • The column header values for the Index field are incorrect
   • The columns are wider than usual, which is incorrect
6. Expected: The columns should be normal size with correct values in the column headers

Scenario C3:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Remove the Index field from Rows deck
4. Click Undo
5. Result: Removal of Index field is undone, but the Index field is now invalid (red), which is incorrect
6. Expected: Index field should be valid

Scenario C4:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Click the Swap Rows and Columns icon
3. Change the Index field in Rows deck to Discrete mode
4. Move the Index field from the Rows deck to the right-most position in the Columns deck
5. Result: Chart fails to render, with "Computing Visualization" gray screen.
6. Expected: Chart should get rendered

Scenario C5:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Hover over the 1st cell (ie the cell with 42,585 value)
4. Click on View Data in the tooltip
5. Click the Summary tab in the View Data dialog
6. Result: The Summary shows wrong values, and there's no column for SUM(Freight), which is incorrect.
7. Expected: The Summary tab should contain the following:
   • Currency Code:
   • YEAR(ShipDate): 2004
   • Index: 1
   • SUM(Freight): 42,583

Scenario C6:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change chart type to Bar
3. Change the Index field in Rows deck to Discrete mode
4. Hover over the 1st bar
5. Click on View Data in the tooltip
6. Click the Summary tab in the View Data dialog
7. Result: The Summary shows wrong values, and there's no column for SUM(Freight), which is incorrect.
8. Expected: The Summary tab should contain the following:
   • Currency Code:
   • YEAR(ShipDate): 2004
   • Index: 1
   • SUM(Freight): 42,583

Scenario C7:

1. Open discrete-measure.vizx in VA, goto Worksheet 5
2. Change chart type to Bar
3. Change the Index field in Rows deck to Discrete mode
4. Hover over the bar for the SUM(Freight) measure at the intersection of "AUD" and "2004
5. Click on View Data in the tooltip
6. Click the Summary tab in the View Data dialog
7. Result: The Summary shows wrong values, and includes a column for SUM(Profit), which is incorrect.
8. Expected: The Summary tab should have a column for SUM(Profit) instead of SUM(Freight). It should contain the following:
   • Currency Code: AUD
   • YEAR(ShipDate): 2004
   • Index: 2
   • SUM(Freight): 9,841

Scenario C8:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Hover over the "44,551" cell and click "Keep Only" in the tooltip
3. Note that "AUD, 2004" is selected in the "Inclusion (...)" filter, which is correct
4. Click Undo to revert the last operation
5. Change the Index field in Rows deck to Discrete mode
6. Again hover over the "44,551" cell and click "Keep Only" in the tooltip
7. Result: The incorrect "inclusion" filter is constructed with only "2004" selected, which is incorrect
8. Expected: The result as in step #3 above is expected

Scenario C9:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Drag Freight from Measures pane to Filters deck, and select "Sum" when the filter options dialog appears
3. Change the SUM(Freight) in Filters deck to Discrete
4. Result: The resulting filter control contains non-aggregated values, which is incorrect
5. Expected: The filter control for SUM(Freight) should contain aggregated values.
   • Option 1: Fix it if it's easy.
   • Option 2: Otherwise we should make Discrete measure fields orange (invalid location) when placed in Filters deck.

Code Review:

Please refactor out the complicated business logic involving loops in the following methods. Those logic should be done in an initialization method, rather than performing those logic every time these methods are invoked. As is, these methods are extremely inefficient, and these methods are invoked in many operations.

• BIRowHeaderTableModel.getColumnCount()
• BIRowHeaderTableModel.getValueAt()
• BIColumnHeaderTableModel.getRowCount()
• BIColumnHeaderTableModel.getValueAt()
• BIDataTableModel.getRowCount()
• BIDataTableModel.getColumnCount()

Functional Review of Dev-70

1. Scenario 7 in this comment is still broken.
2. Scenario B8 in this comment is still broken.
3. Slight variation of Scenario B7 in this comment is broken:
   • Perform all steps in B7
   • Click Swap Rows and Columns
   • Result: Color Legend has only 1 entry, which is incorrect
4. Scenario B9 in this comment is still broken.
5. I added broken Scenario C9 in here.

The following are new breakages:

1. Sorting on Scenario 7 in this comment:
   • Perform all steps in Scenario 7
   • Hover over the SUM(Freight) column header in the "2004" column, and click the sort icon
   • Result: Both the SUM(Freight) and SUM(Profit) column headers show the sort icons, which is incorrect
   • Expected: Only the SUM(Freight) column header should show the sort icon
2. View Data on Scenario 7 in this comment:
   • Perform all steps in Scenario 7
   • Hover over any data cell (ie 10,198 or 159,173)
   • Wait for tooltip to appear, and select View Data
   • Click the Summary tab in the View Data dialog
   • Result: The values for Index and SUM(Freight) are incorrect
   • Expected: The values should be the same as in the tooltip
3. View Data on Scenario B7 in this comment is broken:
   • Perform all steps in B7
   • Hover over a bar (ie Purple)
   • Wait for tooltip to appear and click View Data
   • Click the Summary tab in the View Data dialog
   • Result: The value for Card Type is incorrect
   • Expected: The value should be the same as in the tooltip
4. View Data on slight variation of Scenario B7 in this comment is broken:
   • Perform all steps in B7
   • Click Swap Rows and Columns
   • Hover over a bar (ie Purple)
   • Wait for tooltip to appear and click View Data
   • Click the Summary tab in the View Data dialog
   • Result: The value for Card Type is incorrect
   • Expected: The value should be the same as in the tooltip
5. Tooltip on slight variation of Scenario B7 in this comment is broken:
   • Perform all steps in B7
   • Click the Axes button in Chart Properties, and select "Clustered"
   • Hover over the 1st Purple bar in the "2005" column
   • Wait for tooltip to appear
   • Result: The value for YEAR(ShipDate) is incorrect
   • Expected: The value should be 2005
6. Tooltip on slight variation of Scenario B7 in this comment is broken:
   • Perform all steps in B7
   • Click the Axes button in Chart Properties, and select "Clustered"
   • Click the Swap Rows and Columns icon
   • Hover over the 1st Purple bar in the "2005" row
   • Wait for tooltip to appear
   • Result: The value for YEAR(ShipDate) is incorrect
   • Expected: The value should be 2005
7. Shape Chart
   • Open discrete-measure.vizx in VA, goto Worksheet 1
   • Change the Index field in Rows deck to Discrete mode
   • Click the Swap Rows and Columns icon
   • Change chart type to Shape
   • Result: The chart fails to render, with "Computing Visualization" gray screen.
   • Expected: The chart should render correctly
8. Hover on Shape Chart
   • Open discrete-measure.vizx in VA, goto Worksheet 1
   • Change the Index field in Rows deck to Discrete mode
   • Change chart type to Shape
   • Hover on any Shape in the chart
   • Result: The entire column of shapes are hover-highlighted, which is incorrect
   • Expected: Only the hovered shape should be hover-highlighted
9. Hover on Shape Chart with color
   • Open discrete-measure.vizx in VA, goto Worksheet 1
   • Change the Index field in Rows deck to Discrete mode
   • Change chart type to Shape
   • Drag Card Type to Color deck
   • Hover on any Shape in the 1st column
   • Result: The same colored shapes in the entire 1st two columns are hover-highlighted, which is incorrect
   • Expected: Only the hovered shape should be hover-highlighted
10. Chart Highlighting
    • Open discrete-measure.vizx in VA, goto Worksheet 1
    • Change the Index field in Rows deck to Discrete mode
    • Change chart type to Bar
    • Drag Index field from Rows deck to Color deck
    • Click on any bar
    • Result: The bars in the entire column gets highlighted, which is incorrect
    • Expected: Only the clicked bar should be highlighted
    • Click on any entry in the Index color legend
    • Result: All bars in the chart become gray, which is incorrect
    • Expected: The bars of the selected color should not become gray in the chart; the bars of the non-selected color should become gray.
    • Click the Swap Rows and Columns icon
    • Click on any entry in the Index color legend
    • Result: All bars in the chart become gray, which is incorrect
    • Expected: The bars of the selected color should not become gray in the chart; the bars of the non-selected color should become gray.
11. Chart Highlighting with 2 measures
    • Open discrete-measure.vizx in VA, goto Worksheet 7
    • Change the Index field in Columns deck to Discrete mode
    • Change chart type to Bar
    • Drag Index field from Columns deck to Color deck
    • Click on any bar
    • Result: The bars in the entire column gets highlighted, which is incorrect
    • Expected: Only the clicked bar should be highlighted with black border
    • Click on any entry in the Index color legend
    • Result: All bars in the chart become gray, which is incorrect
    • Expected: The bars of the selected color should not become gray in the chart; the bars of the non-selected color should become gray.
    • Click the Swap Rows and Columns icon
    • Click on any entry in the Index color legend
    • Result: All bars in the chart become gray, which is incorrect
    • Expected: The bars of the selected color should not become gray in the chart; the bars of the non-selected color should become gray.
12. Hover on Bar Chart with Discrete Measure in Color
    • Open discrete-measure.vizx in VA, goto Worksheet 1
    • Change the Index field in Rows deck to Discrete mode
    • Change chart type to Bar
    • Drag Index field in Rows deck to Color deck
    • Hover on any Bar in the char, and wait for the tooltip to appeart
    • Result: The value for the Index field shows a Java object, which is incorrect
    • Expected: The value for the Index field should be an integer

I am observing the following breakages:

Scenario D1:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Right-click on SUM(Freight) in Columns deck, and select Format..., and then select "Percentage"
3. Right-click on SUM(Profit) in Columns deck, and select Format..., and then select "Scientific"
4. Note that the values of SUM(Freight) and SUM(Profit) are formatted accordingly
5. Change the Index field in Columns deck to Discrete mode
6. Result: The formatting for SUM(Freight) and SUM(Profit) values are getting mixed up, which is incorrect
7. Expected: All values should be formatted according to the user selected formats
8. Click the Swap Rows and Columns icon
9. Result: The formatting for SUM(Freight) and SUM(Profit) values are getting mixed up, which is incorrect
10. Expected: All values should be formatted according to the user selected formats
11. Move the Index field from Rows deck to the right-most position in Columns deck
12. Result: The formatting for the measure values get shifted, which is incorrect
13. Expected: All values should be formatted according to the user selected formats

Scenario D2:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Columns deck to Discrete mode
3. Move the Index field from the Columns deck to the right-most position in the Rows deck
4. Hover on the cell at row 6 and last column (ie the cell containing 5,398)
5. Click View Data in the tooltip, and goto the Summary tab in the View Data dialog
6. Result: The values for Index and SUM(Profit) are incorrect
7. Expected: The values in the Summary Tab should match those in the tooltip
8. Change Chart Type to Bar
9. Hover on the cell at row 2 and column 2
10. Click View Data in the tooltip, and goto the Summary tab in the View Data dialog
11. Result: The values for Index and SUM(Profit) are incorrect
12. Expected: The values in the Summary Tab should match those in the tooltip
13. Add Territory field to Color deck
14. Hover on the cell at row 3 and column 2
15. Click View Data in the tooltip, and goto the Summary tab in the View Data dialog
16. Result: The values for Index and SUM(Profit) are incorrect
17. Expected: The values in the Summary Tab should match those in the tooltip

Scenario D3:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Columns deck to Discrete mode
3. Change Chart Type to Bar
4. Add Territory field to Color deck
5. Result:
   • The Index column headers get removed, which is incorrect
   • The bars the chart became black, which is incorrect
   • The bars became very sparse, which is incorrect
   • The Color deck contains a pseudo field called "Multiple Fields", which is incorrect
6. Expected:
   • The chart should look like the attached chart-D3.png

I've attached highlight-fix.patch, which addresses some of the code review concerns here, and removes some  complicated code logic. It should also fix many (but not all) of the highlighting related scenarios.

Please review it. If it doesn't introduce any new breakages, then you may check it in.

Done testing of all the above scenarios and did thorough  testing to make sure the feature is working as expected.

Hence, marking it verified.

Thanks, Juhi

Please fix the following:

Scenario V1:

1. Perform Scenario 5 here
2. Result: The "Index" and measure names columns are too wide
3. Expected: The column widths should be similar to the attached worksheet5.png

Scenario V2:

1. Perform Scenario 6 here
2. Result: The column header for measure names is too tall
3. Expected: The column headers should be similar to the attached worksheet6.png

Scenario V3:

1. Perform Scenario 7 here
2. Result: The column header for measure names is too tall
3. Expected: The column headers should be similar to the attached worksheet7.png

Scenario V4:

1. Perform the Chart mode Scenario 5 here
2. Result: The Index row header values are right-aligned, which is different from left-aligned in Chart mode Scenario 4
3. Move Index in Rows deck to the left-most position
4. Result: The Index row header values become left-aligned
5. Expected: The Index header values should be consistently left-aligned or right-align in all similar scenarios

Scenario V5:

1. Perform Scenario B5 here
2. Hover on the cell at row 1 column 2 (ie the cell with 96,642)
3. Note that the value in the tooltip for SUM(Profit) is 1,233,266
4. Click View Data in the tooltip, then select the Summary tab
5. Result: The value for SUM(Profit) is incorrect
6. Expected: The value for SUM(Profit) should be 1,233,266, same as in the tooltip

Scenario V6:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Remove Index from Rows deck
3. Change chart type to Bar
4. Drag Profit from Measures pane to Label deck in Chart Properties panel
5. Result: The chart fails to render with "Computing Visualization" message
6. Expected: The chart should render successfully

Scenario V7:

1. Perform the Chart mode Scenario 1 here
2. Drag Profit from Measures pane to Label deck in Chart Properties panel
3. Result: The chart fails to render with "Computing Visualization" message
4. Expected: The chart should render successfully

Scenario V8:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Add Profit field to Color deck
5. For the following steps, use the attached profit.png as a reference to see the SUM(Profit) values in each cell.
6. Result: The first bar in the "2006" column is the darkest color, which is incorrect
7. Expected: The first bar in the "2005" column should be the darkest color
8. Hover over the first bar in the "2005" column
9. Result: In the tooltip, the value for SUM(Profit) is incorrect
10. Expected: The value for SUM(Profit) should be 1,233,266
11. Hover over the first bar in the "2006" column
12. Result: In the tooltip, the value for SUM(Profit) is incorrect
13. Expected: The value for SUM(Profit) should be 404,494

Scenario V9:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Shape
4. Add Profit field to Size deck
5. For the following steps, use the attached profit.png as a reference to see the SUM(Profit) values in each cell.
6. Result: The first shape in the "2006" column is the largest, which is incorrect
7. Expected: The first shape in the "2005" column should be the largest
8. Hover over the first shape in the "2005" column
9. Result: In the tooltip, the value for SUM(Profit) is incorrect
10. Expected: The value for SUM(Profit) should be 1,233,266
11. Hover over the first shape in the "2006" column
12. Result: In the tooltip, the value for SUM(Profit) is incorrect
13. Expected: The value for SUM(Profit) should be 404,494

Scenario V10:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Right-click on Index in Rows deck, select Format..., and then select Percentage
3. Result: The Index values are not displayed in percentage format, which is incorrect
4. Change the Index field in Rows deck to Discrete mode
5. Result:
   • The Index values are still not displayed in percentage format, which is incorrect
   • The table columns are too wide, which is incorrect
6. Right-click on Index in Rows deck, select Format..., and then select Automatic
7. Now the table columns are displayed with correct width
8. Expected: Changing the format of Discrete measure field should not widen the table columns

Scenario V11:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change chart type to Shape
3. Right-click on Index in Rows deck, select Format..., and then select Percentage
4. Result: The Index axes are displayed in percentage format, which is correct
5. Convert Index in Rows deck to Discrete
6. Result: The Index values are not displayed in percentage format, which is incorrect
7. Expected: The index values should be displayed in the selected format
8. Move Index field from Rows deck to Color deck
9. Result: The Index values in Color Legend are not displayed in percentage format, which is incorrect
10. Expected: The index values should be displayed in the selected format

Scenario V12:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Move the Index field from Rows deck to Color deck
4. Hover on the "44,551" data cell
5. Result: The Index field is missing in tooltip, which is incorrect
6. Expected: The index field should be displayed in the tooltip with the correct value
7. Click View Data in the tooltip, then select Summary tab
8. Result: The values for Index and SUM(Freight) are incorrect
9. Expected: The values for Index and SUM(Freight) should be displayed correctly
10. Change chart type to Bar
11. Hover on the red bar in the 2004 column, click View Data in the tooltip, then select Summary tab
12. Result: The values for Index and SUM(Freight) are incorrect
13. Expected: The values for Index and SUM(Freight) should be the same as in the tooltip

Scenario V13:

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Rows deck to Discrete mode
3. Move the Index field from Rows deck to Color deck
4. Hover on the "9,841" data cell in Row 2 Column 1
5. Result: The Index field is missing in tooltip, which is incorrect
6. Expected: The index field should be displayed in the tooltip with the correct value
7. Click View Data in the tooltip, then select Summary tab
8. Result: The values for Index and SUM(Freight) are incorrect
9. Expected: The values for Index and SUM(Freight) should be displayed correctly
10. Click the Swap Rows and Columns icon
11. Hover on the "9,841" data cell in Row 1 Column 2
12. Result: The Index field is missing in tooltip, which is incorrect
13. Expected: The index field should be displayed in the tooltip with the correct value
14. Click View Data in the tooltip, then select Summary tab
15. Result: The values for Index and SUM(Freight) are incorrect
16. Expected: The values for Index and SUM(Freight) should be displayed correctly
17. Change chart type to Bar
18. Hover on the red bar in the Row 1, click View Data in the tooltip, then select Summary tab
19. Result: The values for Index and SUM(Freight) are incorrect
20. Expected: The values for Index and SUM(Freight) should be the same as in the tooltip
21. Click the Swap Rows and Columns icon
22. Hover on the red bar in the Column 1, click View Data in the tooltip, then select Summary tab
23. Result: The values for Index and SUM(Freight) are incorrect
24. Expected: The values for Index and SUM(Freight) should be the same as in the tooltip

Scenario V14:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Move Index from Rows deck to Label deck
5. Result: The chart fails to render with "Computing Visualization" message
6. Expected: The chart should render successfully, with Index values as data labels

I've confirmed that scenarios V6, V7 and V14 are existing, and thus not in scope for this project. I was trying to test the functionality of discrete measure in Label deck, and was blocked by V6. However we can test it using Shape chart, which does not exhibit the "Computing Visualization" issue.

Scenario T1:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Shape
4. Move Index from Rows deck to Label deck in Chart Properties panel
5. Result: No data labels are rendered for the Index field
6. Expected: Data labels should be rendered for the Index field
7. Note: For the interest of time, you may disable Discrete Measure field in Label deck like you did for Filter deck. The tooltip message should say:
   • A discrete measure field may not be used in the Label deck. This field is being ignored.

Scenario T2:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Shape
4. Drag Profit from Measures pane to Label deck in Chart Properties panel
5. Expand the row height by 1 cm to make room for the data labels
6. Result: Incorrect SUM(Profit) values are displayed in the data labels. For example, based on the attached profit.png, the data label at Row 1, Column 2 should be 1,233,266
7. Expected: Correct values should be displayed

Scenario T3:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Remove SUM(Freight) from Columns deck
4. Result: Index is missing in the Rows headers, which is incorrect
5. Expected: Index should be in the Row headers
6. Hover over any data cell in the table chart
7. Result: No tooltip is displayed, and the following exception is logged:

   11/28 10:39:45.304 StudioLogger.error 1 >= 1
   java.lang.ArrayIndexOutOfBoundsException: 1 >= 1
   	at java.util.Vector.elementAt(Vector.java:477)
   	at javax.swing.table.DefaultTableColumnModel.getColumn(DefaultTableColumnModel.java:294)
   	at sun.swing.SwingUtilities2.convertColumnIndexToModel(SwingUtilities2.java:1988)
   	at javax.swing.JTable.convertColumnIndexToModel(JTable.java:2582)
   	at javax.swing.JTable.getValueAt(JTable.java:2718)
   	at com.jidesoft.grid.JideTable.getValueAt(Unknown Source)
   	at com.jidesoft.grid.CellSpanTable.getValueAt(Unknown Source)
   	at com.aquafold.bistudio.pivottable.HeaderTable.getStringValueAt(HeaderTable.java:173)
   	at com.aquafold.bistudio.pivottable.RowHeaderTable.getStringValueAt(RowHeaderTable.java:62)
   

8. Expected: Correct tooltip should be displayed, and no exception should occur

Scenario T4:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the SUM(Freight) field in Columns deck to Discrete mode
3. Change chart type to Bar
4. Result: The range in the Index axes are incorrect
5. Expected: The range in the Index axes should be from 0 to 6
6. Remove SUM(Freight) from Columns deck, and observe that axes range is now correct

Scenario T5:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Right-click on Index in Rows deck, select Format..., and then select Percentage
3. Change the Index field in Rows deck to Discrete mode
4. Move Index from Rows deck to Color deck
5. Hover on any data cell in the table chart, and note that the Index value in the tooltip is displayed in percentage format, which is correct
6. Click on View Data in the tooltip, and then select the Summary tab
7. Result: The Index value is not displayed in percentage format, which is incorrect
8. Expected: The Index value should be displayed in the user selected format
9. Change chart type to Bar
10. Hover on any bar in the chart
11. Result: The Index value in the tooltip is not displayed in percentage format, which is incorrect
12. Click on View Data in the tooltip, and then select the Summary tab
13. Result: The Index value is not displayed in percentage format, which is incorrect
14. Expected: The Index value should be displayed in the user selected format

Scenario T6:

1. Perform Scenario V10 here
2. Result: The columns in the table chart is still too wide
3. Expected: The format of the Discrete Measure field should not affect the width of the table chart columns

Scenario T7:

1. Add new worksheet
2. Drag Freight to Columns deck
3. Drag Profit to Rows dec
4. Change chart type to Shape
5. Change SUM(Freight) in Columns deck to Discrete
6. Hover on the shape in the chart
7. Result: In the tooltip, SUM(Freight) is displayed with (null) value, which is incorrect
8. Expected: SUM(Freight) should be displayed with correct value, which is 437, 342

Scenario T8:

1. Add new worksheet
2. Drag Card Type to Columns or Rows deck
3. Result: Chart fails to render, and an Error dialog is displayed with the following in the Show Details section:

   java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
   	at java.util.ArrayList.rangeCheck(ArrayList.java:657)
   	at java.util.ArrayList.get(ArrayList.java:433)
   	at com.aquafold.bistudio.model.BIChartConfigAPI.createNodeTree(BIChartConfigAPI.java:942)
   	at com.aquafold.bistudio.model.BIChartConfigAPI.buildRowTree(BIChartConfigAPI.java:594)
   	at com.aquafold.bistudio.model.BIChartConfigAPI.reconfigure(BIChartConfigAPI.java:533)
   	at com.aquafold.bistudio.model.BIModel.calculateModelImpl(BIModel.java:1241)
   	at com.aquafold.bistudio.model.BIModel.access$200(BIModel.java:168)
   	at com.aquafold.bistudio.model.BIModel$2.process(BIModel.java:882)
   	at com.aquafold.bistudio.component.BISimpleProgressDialog.run(BISimpleProgressDialog.java:96)
   
   

4. Expected: Chart should be rendered correct with no errors

I've attached fix-T-series.patch, which addresses T3 and T8. Please review and test it. If you don't find anything wrong and it doesn't cause new breakages, then you may check it in.

Scenario R1:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Remove SUM(Freight) from Columns deck
4. Change chart type to Bar
5. Hover on any of the column header cells
6. Result: Chart turns gray with "Computing Visualization" message, which is incorrect

I've attached fix-R1.patch which address the above R1 test scenario. Please review and test the patch. If you don't see any problems with it, then you may check it in.

The following scenarios are broken:

Scenario R2:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Result: I am unable to resize the Index row header column

Scenario R4:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Click the Swap Rows and Columns icon
4. Hover any of the column header cells
5. Result: No sort icon is displayed in the columns header cell and I am unable to sort by column, which is incorrect
6. Move SUM(Freight) from Rows deck to Columns deck
7. Hover on the "2005" row header cell, and click the sort icon
8. Result: The sort icon is displayed in both the "2005" and "2006" row header cells, which is incorrect
9. Expected: The sort icon should be displayed on in the row header cell for which the row is being sorted on

Scenario R5:

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Hover on any of the Index row header cells
5. Result: No sort icon is displayed in the Index row header cell, which is incorrect
6. Click on the Swap Rows and Columns icon
7. Hover on any of the Index column header cells
8. Result: No sort icon is displayed in the Index column header cell, which is incorrect
9. Move SUM(Freight) from Rows deck to Columns deck
10. Hover on any of the SUM(Freight) axes and click on the sort icon
11. Result: No sort action is being performed, which is incorrect
12. Click on the Swap Rows and Columns icon
13. Hover on any of the SUM(Freight) axes and click on the sort icon
14. Result: No sort action is being performed, which is incorrect

Scenario R6:

1. Add a new worksheet
2. Drag Freight to Columns deck
3. Drag Card Type to Rows deck
4. Result: The columns headers are rendered incorrectly
5. Expected: The table chart should look like the attached simple-table.png
6. Hover on SUM(Freight) column header cell
7. Result: No sort icon is displayed in the columns header cell and I am unable to sort by column, which is incorrect

The product is looking better!

The following is the current outstanding issues. Please work on the critical issues first, which is the ones labeled as (high), then the (low) ones if you have time. We'll check with PM to make a determination on whether we can defer the (low) ones:

Issue 1 (low):

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Click on any of the Index row header cells
4.     Result: I am unable to click select the header cell

Issue 2 (low):  (this is previously Scenario R2)

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Change chart type to Bar
4.     Result: I am unable to resize the Index row header column

I've split the previous Scenario R5 into 2 parts, a low and high priority part:

Issue 3 (low):

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Change chart type to Bar
4.     Hover on any of the Index row header cells
5.     Result: No sort icon is displayed in the Index row header cell, which is incorrect
6.     Click on the Swap Rows and Columns icon
7.     Hover on any of the Index column header cells
8.     Result: No sort icon is displayed in the Index column header cell, which is incorrect

Issue 4 (high):

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Change chart type to Bar
4.     Move SUM(Freight) from Columns deck to Rows deck
5.     Click on the Swap Rows and Columns icon
6.     Hover on any of the SUM(Freight) axes and click on the sort icon
7.     Result: No sort action is being performed, which is incorrect

Issue 5 (high):

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Drag select the 1st 2 data cells (ie the 42,583 and 44,551 cells)
4.     Hover on the highlighted cells
5.     Result: The tooltip rendered with the "2 measure values selected" section missing
6.     Click View Data in the tooltip, and select the Summary tab in the View Data dialog
7.     Result: The Summary tab does not contain any data for the selected cells
8.     Expected: The Summary tab should contain data for the selected cells
9.     Close the View Data dialog
10.     Again hover on the highlighted cells, and select "Keep Only" in the tooltip
11.     Result: The Inclusion filter is added with no entries selected
12.     Expected: The entries in the Inclusion filter corresponding to the highlighted cells should be selected
13.     Click Undo
14.     Again drag select the 1st 2 data cells (ie the 42,583 and 44,551 cells)
15.     Hover on the highlighted cells, and select "Exclude" in the tooltip
16.     Result: The Exclusion filter is added with no entries selected
17.     Expected: The entries in the Exclusion filter corresponding to the highlighted cells should be selected

Hi,

The high priority issues i.e. issue #4 and issue #5, reported above are fixed and the code is committed.

The revision details are below:

Dev-80

Please fix the (high) priority issues only. We'll create new separate issues for the (low) priority issues for next release.

Issue 80-1 (high -- this is a slight variation of Issue 5 above):

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Shape
4. Move Index from Rows deck to any of Color deck (Note that this issue occurs also for Size, Break and Label decks, but only Color deck is high priority because Issue #15376 explicitly support Discrete Measure color field)
5. Drag select the 1st 2 data cells in the "2004" column
6. Hover on the highlighted cells
7. Result: The tooltip rendered with the "2 measure values selected" section missing
8. Click View Data in the tooltip, and select the Summary tab in the View Data dialog
9. Result: The Summary tab does not contain any data for the selected cells
10. Expected: The Summary tab should contain data for the selected cells
11. Close the View Data dialog
12. Again hover on the highlighted cells, and select "Keep Only" in the tooltip
13. Result: The Inclusion filter is added with no entries selected
14. Expected: The entries in the Inclusion filter corresponding to the highlighted cells should be selected
15. Click Undo
16. Again drag select the 1st 2 data cells (ie the 42,583 and 44,551 cells)
17. Hover on the highlighted cells, and select "Exclude" in the tooltip
18. Result: The Exclusion filter is added with no entries selected
19. Expected: The entries in the Exclusion filter corresponding to the highlighted cells should be selected

Issue 80-2 (high -- also related Issue 5 above):

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Hover on the 1st SUM(Freight) axis and click the sort icon
5. Hover on the 1st row header cell and click the sort icon
6. Drag select the 1st two data cells in the 1st column
7. Hover on the highlighted cells, and select "Keep Only" in the tooltip
8. Result: An error dialog is displayed with the following exception in the Details section:
   

   java.lang.ArrayIndexOutOfBoundsException: -1
   	at java.util.ArrayList.elementData(ArrayList.java:422)
   	at java.util.ArrayList.get(ArrayList.java:435)
   	at com.aquafold.bistudio.model.BIRowHeaderTableModel.getValuesAt(BIRowHeaderTableModel.java:727)
   	at com.aquafold.bistudio.model.BIModel.syncSortByValueIndex(BIModel.java:2272)
   	at com.aquafold.bistudio.model.BIModel.syncSortByValueIndices(BIModel.java:1891)
   	at com.aquafold.bistudio.model.BIModel.applyFieldSortInternal(BIModel.java:1880)
   	at com.aquafold.bistudio.model.BIModel.internalResetDefaultSort(BIModel.java:2231)
   	at com.aquafold.bistudio.model.BIModel.applySortByRowColumn(BIModel.java:2146)
   	at com.aquafold.bistudio.model.BIModel.applySortByRowColumn(BIModel.java:1993)
   	at com.aquafold.bistudio.model.BIModel.calculateModelImpl(BIModel.java:1240)
   	at com.aquafold.bistudio.model.BIModel.access$200(BIModel.java:168)
   	at com.aquafold.bistudio.model.BIModel$2.process(BIModel.java:882)
   	at com.aquafold.bistudio.component.BISimpleProgressDialog.run(BISimpleProgressDialog.java:96)
   
   

9. Expected: The chart should be rendered correctly with no error

Issue 80-3 (low)

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Hover on the "3" row header cell, and click the sort icon
4. Drag highlight all cells in rows 2 and 3.
5. Hover on the highlighted cells and select "Keep Only" in the tooltip
6. Click Undo
7. Result: The sort icon is lost
8. Change chart type to Bar
9. Hover on the "CAD" row header cell, and click the sort icon
10. Drag highlight all cells in rows 2 and 3.
11. Hover on the highlighted cells and select "Keep Only" in the tooltip
12. Result: The sort icon is no longer displayed after the Keep Only action
13. Click Undo
14. Result: The sort icon is still not restored
15. Again hover on the "CAD" row header cell, and click the sort icon
16. Use Ctrl-left-click to select the "AUD" and "CAD" row header cells
17. Hover on the highlighted row header cells and select "Keep Only" in the tooltip
18. Result: The sort icon is no longer displayed after the Keep Only action
19. Click Undo
20. Result: The sort icon is still not restored
     

Issue 80-3 (low -- this is the first sub-bullet of item #4 in the main issue discription, and also in the PRD)

1. Open discrete-measure.vizx in VA, goto Worksheet 6
2. Change the Index field in Rows deck to Discrete mode
3. Click any of the visualizations inside the "Visualization" drop down at the top right of the VA window (For example the Bubble chart visualization)
4. Result: The Index field is not converted to Continuous, which is incorrect
5. Expected: During visualization, all Discrete measure fields should be converted to Continuous first, then the visualization specific logic applied.

The following are copied from the previous issue list:

Issue 1 (low):

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Click on any of the Index row header cells
4.     Result: I am unable to click select the header cell

Issue 2 (low):  (this is previously Scenario R2)

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Change chart type to Bar
4.     Result: I am unable to resize the Index row header column

Issue 3 (low):

1.     Open discrete-measure.vizx in VA, goto Worksheet 1
2.     Change the Index field in Rows deck to Discrete mode
3.     Change chart type to Bar
4.     Hover on any of the Index row header cells
5.     Result: No sort icon is displayed in the Index row header cell, which is incorrect
6.     Click on the Swap Rows and Columns icon
7.     Hover on any of the Index column header cells
8.     Result: No sort icon is displayed in the Index column header cell, which is incorrect

Issues 80-1 and 80-2 are fixed and the revision details are given below:

Revision: 56356
Date: Tuesday, December 4, 2018 6:02:46 PM
Message:
<visualanalytics:#15442> Fixed high priority scenarios 80-1 and 80-2

Dev-81

Issue 81-1 (high)

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Drag select so that cells(r,c): (1,1), (1,2), (2,1), (2,2) are highlighted
5. Hover on the highlighted cells, and select "Keep Only" in the tooltip
6. Result: The SUM(Freight) axis scale is too small such that the bars in the 2nd column exceeded the scale
7. Expected: The scale of the axis should be appropriate to accommodate the available data point in the chart

Issue 81-2 (high -- related to Issue 5 in another comment)

1. Open discrete-measure.vizx in VA, goto Worksheet 4
2. Change the Index field in Rows deck to Discrete mode
3. The following tests (steps 4 - 12) should be repeated for each of the following possible permutations:
   • Chart Types: Table and Bar
   • Move Index field to each of the following positions:
     • left-most position in Columns deck
     • 2nd position in Columns deck
     • last position in Columns dec
     • left-most position in Rows deck
     • 2nd position in Rows deck
     • last position in Rows deck
   • Move SUM(Freight) field to Columns and Rows deck
4. Drag select the 1st two cells in the 1st column
5. Hover on the highlighted cells, and select "Keep Only" in the tooltip
6. Result: An Inclusion filter is added with nothing selected, causing the table to be blank
7. Expected: The entries in the Inclusion filter corresponding to the highlighted cells should be selected
8. Click Undo
9. Drag select the 1st two cells in the 1st column
10. Hover on the highlighted cells, and select "Exclude" in the tooltip
11. Result: An Exclusion filter is added with nothing selected
12. Expected: The entries in the Exclusion filter corresponding to the highlighted cells should be selected

Issue 81-3 (high -- this may be related to 81-2. Fixing 81-2 may also fix 81-3)

1. Open discrete-measure.vizx in VA, goto Worksheet 4
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Move the Index field in Rows deck to the left-most position
5. Hover on the 1st column header cell and click the sort icon
6. Hover on the 1st row header cell and click the sort icon
7. Drag select the 1st two cells in the 1st column
8. Hover on the highlighted cells, and select "Keep Only" in the tooltip
9. Result: An error dialog is displayed with the following exception in the Details section

   java.lang.ArithmeticException: / by zero
   	at com.aquafold.bistudio.model.BIRowHeaderTableModel.getValuesAt(BIRowHeaderTableModel.java:725)
   	at com.aquafold.bistudio.model.BIModel.syncSortByValueIndex(BIModel.java:2272)
   	at com.aquafold.bistudio.model.BIModel.syncSortByValueIndices(BIModel.java:1891)
   	at com.aquafold.bistudio.model.BIModel.applyFieldSortInternal(BIModel.java:1880)
   	at com.aquafold.bistudio.model.BIModel.internalResetDefaultSort(BIModel.java:2231)
   	at com.aquafold.bistudio.model.BIModel.applySortByRowColumn(BIModel.java:2146)
   	at com.aquafold.bistudio.model.BIModel.applySortByRowColumn(BIModel.java:1993)
   	at com.aquafold.bistudio.model.BIModel.calculateModelImpl(BIModel.java:1240)
   	at com.aquafold.bistudio.model.BIModel.access$200(BIModel.java:168)
   	at com.aquafold.bistudio.model.BIModel$2.process(BIModel.java:882)
   	at com.aquafold.bistudio.component.BISimpleProgressDialog.run(BISimpleProgressDialog.java:96)
   
   

10. Expected: The chart should be rendered correctly without errors

Issue 81-4 (low)

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Drag Card Type to Color deck
5. Right-click on Card Type in Color deck, and select the Sort menu
6. Result: The "Measure Values" option is not available
7. Expected: Since there's only one continuous measure, we should be able to sort the color field by Measure Values. For example, if you remove the Index field, then the "Measure Values" option becomes available.

Issue 81-5 (low)

1. Open discrete-measure.vizx in VA, goto Worksheet 7
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Click the Axes button in Chart Properties panel, and select "Merged Axes, Shared Scale"
5. Remove the SUM(Profit) field from Columns deck
6. Result: Even though there's only 1 measure, the chart is still in "Merged Axes" mode. This is apparent because the "Measure Names" field is still in the Color deck, which is the case only in Dual or Merged Axes mode.
7. Expected: Since there's only one continuous measure, the axes mode should be "Individual Axis".

<visualanalytics:#15442> Fixed high priority scenarios 81-1, 81-2 and 81-3

Changes:
1.  Fixed high priority scenarios 81-1, 81-2 and 81-3

At revision: 56359

Dev-82

Issue 82-1 (high -- regression on sorting and highlighting)

1. Open discrete-measure.vizx in VA, goto Worksheet 4
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Hover on the "2004" column header, and click on the sort icon
5. Result: The "2005" column is being sorted
6. Move the Index field in Rows deck to the 2nd position
7. Hover on the "ColonialVoice" row header cell
8. Result:
   • No sort icon is available; thus the sort by row feature is broken
   • No click select action is available; thus the highlighting feature is broken
9. Expected:
   • A sort icon should be displayed in the row header cell upon hovering
   • I should be able to click on the row header to highlight the entire row
10. Move the Index field in Rows deck to the left-most position
11. Hover on the "ColonialVoice" row header cell
12. Result:
    • No sort icon is available; thus the sort by row feature is broken
    • No click select action is available; thus the highlighting feature is broken
13. Expected:
    • A sort icon should be displayed in the row header cell upon hovering
    • I should be able to click on the row header to highlight the entire row
14. Hover on the "AUD" row header cell
15. Result: No click select action is available; thus the highlighting feature is broken
16. Expected: I should be able to click on the row header to highlight all rows under the "AUD" header
17. Click the Swap Rows and Columns icon
18. Hover on the "ColonialVoice" column header cell
19. Result:
    • No sort icon is available; thus the sort by column feature is broken
    • No click select action is available; thus the highlighting feature is broken
20. Expected:
    • A sort icon should be displayed in the column header cell upon hovering
    • I should be able to click on the column header to highlight the entire column
21. Hover on the "AUD" column header cell
22. Result: No click select action is available; thus the highlighting feature is broken
23. Expected: I should be able to click on the column header to highlight all columns under the "AUD" header

Issue 82-2 (high) -- I am unable to verify Issue 81-3 because of Issue 82-1regression, which is caused by the Dev-82 build. For example I am not able to perform step 6 of Issue 81-3 in build Dev-82.

Issue 82-1 (high -- regression on sorting and highlighting) till #5, is fixed. The other issues related to charts sorting and highlighting are not fixed because of the problem we described in R5 charts sorting and R2. Please refer that section.

.Changes:

At revision: 56361

Dev-83

Issue 83-1 (low -- carried over from 82-1 since only the result in step 5 of 82-1 was fixed. Also this is different from R5 in another comment, where there was an easy work-around for the user. The work-around for 83-1 involves more steps that the user needs to perform.)

1. Open discrete-measure.vizx in VA, goto Worksheet 4
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Move the Index field in Rows deck to the 2nd position
5. Hover on the "ColonialVoice" row header cell
6. Result:
   • No sort icon is available; thus the sort by row feature is broken
   • No click select action is available; thus the highlighting feature is broken
7. Expected:
   • A sort icon should be displayed in the row header cell upon hovering
   • I should be able to click on the row header to highlight the entire row
8. Move the Index field in Rows deck to the left-most position
9. Hover on the "ColonialVoice" row header cell
10. Result:
    • No sort icon is available; thus the sort by row feature is broken
    • No click select action is available; thus the highlighting feature is broken
11. Expected:
    • A sort icon should be displayed in the row header cell upon hovering
    • I should be able to click on the row header to highlight the entire row
12. Hover on the "AUD" row header cell
13. Result: No click select action is available; thus the highlighting feature is broken
14. Expected: I should be able to click on the row header to highlight all rows under the "AUD" header
15. Click the Swap Rows and Columns icon
16. Hover on the "ColonialVoice" column header cell
17. Result:
    • No sort icon is available; thus the sort by column feature is broken
    • No click select action is available; thus the highlighting feature is broken
18. Expected:
    • A sort icon should be displayed in the column header cell upon hovering
    • I should be able to click on the column header to highlight the entire column
19. Hover on the "AUD" column header cell
20. Result: No click select action is available; thus the highlighting feature is broken
21. Expected: I should be able to click on the column header to highlight all columns under the "AUD" header

Issue 83-2 (high)

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Move SUM(Freight) from Columns deck to Rows deck
5. Drag Territory to Color deck
6. Click the Axis button in Chart Properties panel, and select "Stacked"
7. Result:
   • The Index row header values are displayed as 1, 1, 2, 2, 3, 3, 2 -- which is incorrect
   • The scale of the SUM(Freight) axis becomes 0 to 60K, causing the bars in the 1st row to be truncated.
   • The "GBP" row contains 2 SUM(Freight) axes, which is incorrect
8. Expected:
   • The Index row header values should be 1, 2, 3, 4, 5, 6 -- same as prior to adding the color field
   • The chart should be rendered with the appropriate scale. Note removing the Index field will show the correct scale.
   • The "GBP" row should contain only one axis
9. Hover and click on each of the "AUD", "CAD", "DEM", "FRF", "GBP" headers.
10. Result: The incorrect row is highlighted
11. Expected: The row corresponding to the click header should be highlighted
12. Click the Axis button in Chart Properties panel, and select "Clustered"
13. Result:
    • The Index row header values are displayed as 1, 1, 2, 2, 3, 3, 2 -- which is incorrect
    • The scale of the SUM(Freight) axis becomes 0 to 40K, causing the bars in the 2nd row to be truncated.
    • The "GBP" row contains 2 SUM(Freight) axes, which is incorrect
14. Expected:
    • The Index row header values should be 1, 2, 3, 4, 5, 6 -- same as prior to adding the color field
    • The chart should be rendered with the appropriate scale. Note removing the Index field will show the correct scale.
    • The "GBP" row should contain only one axis
15. Hover and click on each of the "AUD", "CAD", "DEM", "FRF", "GBP" headers.
16. Result: The incorrect row is highlighted
17. Expected: The row corresponding to the click header should be highlighted
18. Right click on YEAR(ShipDate) in Columns deck and select "Quarter (Q4 2004)" in the 2nd date grouping. This date grouping should have a year component and changes the field to Continuous.
19. Repeat steps 6 through 11

Dev-84

Issue 84-1 (low -- carried over from the unfixed parts of 83-2)

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Change chart type to Bar
4. Move SUM(Freight) from Columns deck to Rows deck
5. Drag Territory to Color deck
6. Click the Axis button in Chart Properties panel, and select "Stacked"
7. Result:
   • The Index row header values are displayed as 1, 1, 2, 2, 3, 3, 2 -- which is incorrect (This is an existing bug)
   • The "GBP" row contains 2 SUM(Freight) axes, which is incorrect (This may be partially related to the existing bug in the 1st bullet)
8. Expected:
   • The Index row header values should be 1, 2, 3, 4, 5, 6 -- same as prior to adding the color field
   • The "GBP" row should contain only one axis
9. Click the Axis button in Chart Properties panel, and select "Clustered"
10. Result:
    • The Index row header values are displayed as 1, 1, 2, 2, 3, 3, 2 -- which is incorrect
    • The "GBP" row contains 2 SUM(Freight) axes, which is incorrect
11. Expected:
    • The Index row header values should be 1, 2, 3, 4, 5, 6 -- same as prior to adding the color field
    • The "GBP" row should contain only one axis
12. Right click on YEAR(ShipDate) in Columns deck and select "Quarter (Q4 2004)" in the 2nd date grouping. This date grouping should have a year component and changes the field to Continuous.
13. Repeat steps 6 through 8

Issue 84-2 (high -- this is a regression of an existing feature)

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Remove the Index field from Rows deck
3. Change chart type to Bar
4. Drag Territory to Color deck
5. Drag select 2 bars in the chart. Make sure to test with some variations which bars and number of bars to highlight.
6. Hover on highlighted bars
7. Result: The tooltip rendered with the "2 measure values selected" section missing. Also the View Data > Summary tab will also be empty due to this. Make sure to test this as well.
8. Click "Keep Only" or "Exclude" in the tooltip. Make sure you test both for your fix.
9. Result: The Inclusion or Exclusion filter is added without any selected entries
10. Expected: The entries in the Inclusion and Exclusion filter corresponding to the highlighted cells should be selected.
11. Move SUM(Freight) from Columns deck to Rows deck, and repeat the above steps.
12. Right click on YEAR(ShipDate) in Columns deck and select "Quarter (Q4 2004)" in the 2nd date grouping, and repeat the above steps.

Dev-85

Issue 85-1 (high)

1. Open discrete-measure.vizx in VA, goto Worksheet 1
2. Change the Index field in Rows deck to Discrete mode
3. Drag Profit to Color deck
4. Click Swap Rows and Columns
5. Result: The column headers for Currency Code is rendered as "<blank>, <blank>, AUD, CAD, DEM, DEM", which is incorrect
6. Hover on the "2005" row header and click the sort icon
7. Result:
   • The column headers for Currency Code is rendered as "GBP, GBP, FRF, DEM, CAD, CAD", which is incorrect
   • The "2005" row is not sorted correctly
8. Clear the sorting
9. Drag select the 1st two cells in row 1, and select Keep Only in the tooltip
10. Result: Only 1 entry is selected in the Inclusion filter, which is incorrect
11. Change Chart Type to Bar
12. Drag select the 1st two cells in row 1, and select Keep Only in the tooltip
13. Result:
    • Only 1 entry is selected in the Inclusion filter, which is incorrect
    • The chart is rendered without any actual values for the Currency Code column header

Please see Link below for Demo of Video High Priority 85-1

https://drive.google.com/file/d/1kZ9bsYO-0VgnIyI_Yt8bEd8eU9OmPSb0/view?usp=sharing

Hi Nhi,

I checked-in the fix of Issue 85-1 in below mentioned revision. All existing scenarios are working fine.

Verified all the above scenarios and its working fine.

Hence, marking it verified.